Bug 196495 - net-mgmt/xymon-server: xymonnet crash after update to 4.3.18
Summary: net-mgmt/xymon-server: xymonnet crash after update to 4.3.18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-04 18:36 UTC by Michael Moll
Modified: 2015-01-05 14:18 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (feld)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Moll freebsd_committer 2015-01-04 18:36:52 UTC
After updating xymon-server to 4.3.18, xymonnet started to crash when checking network services. I could trace this back to http://sourceforge.net/p/xymon/code/7484/tree//branches/4.3.18/xymonnet/dns2.c?diff=516c17fd34309d2eb14bcb64:7483 and indeed I'm using AAAA records. Appending a NULL to addtobuffer_many()'s arguments worked for me to prevent the crash, but no idea if that's really correct.
Comment 1 Bugzilla Automation freebsd_committer 2015-01-04 18:36:52 UTC
Auto-assigned to maintainer feld@FreeBSD.org
Comment 2 Mark Felder freebsd_committer 2015-01-05 13:40:50 UTC
Hey that's fantastic! I recently hit this as well and I couldn't figure it out. It was only crashing for me on the DNS check and I suspected it may have been related to other issues people have had in the past with c-ares, but disabling c-ares for xymonnet didn't work! I disabled my DNS checks as a temporary workaround.

I dont know if the NULL is appropriate but if it works that's good news. I'll see what I can figure out.

Thanks for the report! I'll get a patch into ports as soon as possible.
Comment 3 commit-hook freebsd_committer 2015-01-05 14:00:55 UTC
A commit references this bug:

Author: feld
Date: Mon Jan  5 14:00:04 UTC 2015
New revision: 376300
URL: https://svnweb.freebsd.org/changeset/ports/376300

Log:
  Add patch to fix xymonnet crashing when a DNS check returns an AAAA
  record

  PR:		196495
  Submitted by:	kvedulv@kvedulv.de

Changes:
  head/net-mgmt/xymon-server/Makefile
  head/net-mgmt/xymon-server/files/patch-xymonnet_dns2.c
Comment 4 Mark Felder freebsd_committer 2015-01-05 14:18:05 UTC
You were correct. addtobuffer_many() in case T_AAAA is a variadic function that needs to terminate in a NULL.

I've also emailed the xymon mailing list. Hopefully it will be incorporated into the next release.