Bug 196504 - [patch] sysutils/munin-common: plugin "iostat" wrongly labels kB/s as MB/s
Summary: [patch] sysutils/munin-common: plugin "iostat" wrongly labels kB/s as MB/s
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 11:54 UTC by VK
Modified: 2015-01-19 17:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
sysutils_munin-common.r376291.diff (974 bytes, patch)
2015-01-05 11:54 UTC, VK 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VK freebsd_triage 2015-01-05 11:54:54 UTC 
Created attachment 151350 [details]
sysutils_munin-common.r376291.diff

The sysutils/munin-common (2.0.25) plugin "iostat" wrongly labels "MB per second read+write" and should instead label "kB per second read+write". The values are directly taken from /usr/sbin/iostat which shows kB/sec.

Patch against the SVN tree (revision 376291) attached. The "iostat" plugin already has a patchfile, so this modifies that patchfile to include these additional changes.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-05 11:54:54 UTC 
Auto-assigned to maintainer mat@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-01-19 17:48:26 UTC 
A commit references this bug:

Author: mat
Date: Mon Jan 19 17:47:48 UTC 2015
New revision: 377445
URL: https://svnweb.freebsd.org/changeset/ports/377445

Log:
  Fix the iostat plugin to report the correct unit. [1]
  Fix common plugins PATH problems by adding LOCALBASE/{bin,sbin} to the default
  PATH.  Fix a " that should not have been there.  Fix a few permissions
  problems. [2]

  PR:		196504 [1]
  Submitted by:	Vlad "Blackflow" K.
  PR:		196739 [2]
  Submitted by:	darius dons net au
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-common/files/patch-plugins_node.d.freebsd_iostat.in
  head/sysutils/munin-node/Makefile
  head/sysutils/munin-node/files/plugins.conf.in