Bug 196523 - [devel/xdg-user-dirs] PATCH: Change directory "/etc/xdg" to "/usr/local/etc/xdg" in manpages
Summary: [devel/xdg-user-dirs] PATCH: Change directory "/etc/xdg" to "/usr/local/etc/x...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 00:01 UTC by Jordan Irwin
Modified: 2016-08-23 18:42 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+

Attachments
Patch for user-dirs.defaults manpage (917 bytes, patch)
2015-01-06 00:01 UTC, Jordan Irwin 		no flags Details | Diff
Patch for user-dirs.dirs manpage (516 bytes, patch)
2015-01-06 00:02 UTC, Jordan Irwin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jordan Irwin 2015-01-06 00:01:59 UTC 
Created attachment 151366 [details]
Patch for user-dirs.defaults manpage

The upstream manpages for devel/xdg-user-dirs defines the xdg directory location in "/etc/xdg". But on FreeBSD systems the location is "/usr/local/etc/xdg". The included patches change this directory in the manpages xml files.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-06 00:01:59 UTC 
Auto-assigned to maintainer kde@FreeBSD.org
Comment 2 Jordan Irwin 2015-01-06 00:02:28 UTC 
Created attachment 151367 [details]
Patch for user-dirs.dirs manpage
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-01-06 17:58:28 UTC 
Thanks for the patches. I think there's room for improvement here. Instead of patching those files, you could call ${REINPLACE_CMD} in the Makefile's post-patch target and replace /etc with ${LOCALBASE}/etc so that it always reflects the reality.

You get bonus points if you also submit a bug report upstream (or provide a patch) that just makes the text more platform-independent so that the whole substitution process is made unnecessary in the future.
Comment 4 Jordan Irwin 2015-01-07 02:45:59 UTC 
Thanks for the info. I will look into learning how to use the ${REINPLACE_CMD}. I just submitted my first Port yesterday, so I'm not very experienced.
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-22 12:10:49 UTC 
Hey Jordan, are you still working on this? Do you need help with the patch?
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-08-23 18:42:26 UTC 
Timeout; closing.