Bug 196850 - audio/musicpd fails to build with GCC 4.9 (even though it claims USE_GCC=yes)
Summary: audio/musicpd fails to build with GCC 4.9 (even though it claims USE_GCC=yes)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks: 196712
  Show dependency tree / graph
 
Reported: 2015-01-18 22:32 UTC by Gerald Pfeifer
Modified: 2015-03-22 22:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (crees)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2015-01-18 22:32:03 UTC 
This is important since it blocks the upgrade of the default version
of GCC from GCC 4.8 to GCC 4.9.  If you cannot fix it, please change
to USE_GCC=4.8 temporarily.

http://package18.nyi.freebsd.org/data/101amd64-default-PR196712/2015-01-16_07h05m42s/logs/errors/musicpd-0.18.11_5.log

g++49 -DHAVE_CONFIG_H -I.  -DNDEBUG -I./src -pthread -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -isystem /usr/local/include -DSYSTEM_CONFIG_FILE_LOCATION='"/usr/local/etc/mpd.conf"'  -I/usr/local/include -I/usr/local/include -std=gnu++0x -O2 -pipe -I/usr/local/include -fstack-protector -Wl,-rpath=/usr/local/lib/gcc49 -fno-strict-aliasing  -Wl,-rpath=/usr/local/lib/gcc49 -fvisibility=hidden -fno-threadsafe-statics -fmerge-all-constants -fno-exceptions -fno-rtti -ffast-math -ftree-vectorize -ffunction-sections -fdata-sections -Wall -Wextra -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wwrite-strings -Wsign-compare -MT src/playlist/libplaylist_plugins_a-PlsPlaylistPlugin.o -MD -MP -MF src/playlist/.deps/libplaylist_plugins_a-PlsPlaylistPlugin.Tpo -c -o src/playlist/libplaylist_plugins_a-PlsPlaylistPlugin.o `test -f 'src/playlist/PlsPlaylistPlugin.cxx' || echo './'`src/playlist/PlsPlaylistPlugin.cxx
src/playlist/PlsPlaylistPlugin.cxx: In function 'void pls_parser(GKeyFile*, std::forward_list<SongPointer>&)':
src/playlist/PlsPlaylistPlugin.cxx:64:37: error: 'sprintf' was not declared in this scope
   sprintf(key, "File%u", num_entries);
                                     ^
Makefile:6757: recipe for target 'src/playlist/libplaylist_plugins_a-PlsPlaylistPlugin.o' failed

http://package18.nyi.freebsd.org/data/93i386-default-PR196712/2015-01-18_16h
49m19s/logs/errors/musicpd-0.18.11_5.log
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-18 22:32:03 UTC 
Auto-assigned to maintainer gblach@FreeBSD.org
Comment 2 Grzegorz Blach freebsd_committer freebsd_triage 2015-01-19 00:12:11 UTC 
Bug was wrongly assigned.
Comment 3 Chris Rees freebsd_committer freebsd_triage 2015-03-22 22:06:20 UTC 
Hm, I think just adding cstdio should help- testing.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2015-03-22 22:08:32 UTC 
Oh, it no longer has USE_GCC anyway, so isn't a blocker for upgrade. Please go ahead- I'm sorry for the delay in replying.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-03-22 22:35:55 UTC 
A commit references this bug:

Author: crees
Date: Sun Mar 22 22:35:26 UTC 2015
New revision: 381967
URL: https://svnweb.freebsd.org/changeset/ports/381967

Log:
  Update to 0.18.23

  fixes build with GCC (explicit stdio inclusion required)

  0.19 will come once I've had more time to test.

  PR:		ports/196850

Changes:
  head/audio/musicpd/Makefile
  head/audio/musicpd/distinfo