Bug 196968 - deskutils/akamaru requires -lm when building with external toolchain
Summary: deskutils/akamaru requires -lm when building with external toolchain
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-21 15:48 UTC by Sean Bruno
Modified: 2015-02-12 20:50 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pneumann)

Attachments
patch (770 bytes, patch)
2015-01-23 19:35 UTC, Tijl Coosemans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2015-01-21 15:48:41 UTC 
We need an explicit link against libm when using a non-default toolchain.  This is used in the cross build of arm/mips ports.

http://chips.ysv.freebsd.org/data/11armv6-11armv6/2015-01-19_15h28m19s/logs/errors/akamaru-0.1_9.log

My attempts to add -lm to this ports LDFLAGS have failed.  Unsure how to do this.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-21 15:48:41 UTC 
Maintainer CC'd
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2015-01-23 19:35:13 UTC 
Created attachment 152059 [details]
patch

This patch makes the port respect CFLAGS, CPPFLAGS, LDFLAGS and LIBS and should fix the issue.
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2015-01-23 20:00:16 UTC 
Looks good on ARM with ext toolchain things here:

http://tasty.ysv.freebsd.org/data/11armv6-11-armv6-ports/2015-01-23_19h51m00s/logs/akamaru-0.1_10.log
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-12 20:49:23 UTC 
A commit references this bug:

Author: sbruno
Date: Thu Feb 12 20:48:27 UTC 2015
New revision: 378894
URL: https://svnweb.freebsd.org/changeset/ports/378894

Log:
  This patch makes the port respect CFLAGS, CPPFLAGS, LDFLAGS and LIBS.  Fixes builds with
  external toolchains (qemu enabled poudriere jails).

  PR:		196968
  Submitted by:	tijl
  Approved by:	maintainer timeout

Changes:
  head/deskutils/akamaru/Makefile