Bug 197024 - net/haproxy: rc.d script doesn't kill all processes on stop
Summary: net/haproxy: rc.d script doesn't kill all processes on stop
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-23 07:49 UTC by Artyom Davidov
Modified: 2015-02-09 13:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (demon)


Attachments
Patch for the HAProxy rc.d script (598 bytes, patch)
2015-01-23 07:49 UTC, Artyom Davidov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Artyom Davidov 2015-01-23 07:49:15 UTC
Created attachment 152049 [details]
Patch for the HAProxy rc.d script

When HAProxy is started with nbproc > 1 the default rc.d script is unable to stop all the running processes due to the way the PID file is being parsed in rc.subr

Attached a patch that changes a stop command to handle multiple PIDs in one PID file.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-23 07:49:15 UTC
Auto-assigned to maintainer demon@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-02-09 13:06:30 UTC
A commit references this bug:

Author: demon
Date: Mon Feb  9 13:06:12 UTC 2015
New revision: 378727
URL: https://svnweb.freebsd.org/changeset/ports/378727

Log:
  Fix stop action to stop correctly multi-process haproxy instance.

  PR:		197024
  Submitted by:	ard_1@mail.ru

Changes:
  head/net/haproxy/files/haproxy.in