Bug 197034 - devel/git-review: Missing dependency on py-requests
Summary: devel/git-review: Missing dependency on py-requests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-01-23 18:58 UTC by Marcel Moolenaar
Modified: 2015-01-25 09:18 UTC (History)
2 users (show)

See Also:
dereckson: maintainer-feedback+

Attachments
patch against r377835 to fix the issue (451 bytes, patch)
2015-01-24 22:54 UTC, dereckson 		dereckson: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Moolenaar freebsd_committer freebsd_triage 2015-01-23 18:58:40 UTC 
On a pristine 10.1 FreeBSD installation with git-review installed, running git-review gives:

marcel@fbsd % git-review
Traceback (most recent call last):
  File "/usr/local/bin/git-review", line 6, in <module>
    from git_review.cmd import main
  File "/usr/local/lib/python2.7/site-packages/git_review/cmd.py", line 31, in <module>
    import requests
ImportError: No module named requests
marcel@fbsd %

Manual installation of py27-requests (2.4.3) fixed this problem:

marcel@fbsd % git-review
No '.gitreview' file found in this repository. We don't know where
your gerrit is. Please manually create a remote named "gerrit" and try
again.

.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-24 07:59:48 UTC 
CC Maintainer. 

Using category/portname: in issue title will automatically assign or cc maintainers .
Comment 2 dereckson 2015-01-24 22:54:04 UTC 
Created attachment 152111 [details]
patch against r377835 to fix the issue
Comment 3 dereckson 2015-01-24 22:57:01 UTC 
Thank you for reporting this.

The last version of git-review indeed introduces the Requests library as a new dependency.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-25 09:17:11 UTC 
A commit references this bug:

Author: koobs
Date: Sun Jan 25 09:16:31 UTC 2015
New revision: 377872
URL: https://svnweb.freebsd.org/changeset/ports/377872

Log:
  devel/git-review: Add missing dependency

  - Add missing RUN_DEPENDS on py-requests

  While I'm here:

  - Add LICENSE_FILE
  - Sort USE_PYTHON

  PR:		197034
  Submitted by:	maintainer <dereckson espace-win org>

Changes:
  head/devel/git-review/Makefile
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-25 09:18:05 UTC 
Committed, thank you!