Bug 197056 - print/fontforge: unbreak on 8.x
Summary: print/fontforge: unbreak on 8.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-24 21:38 UTC by Jan Beich
Modified: 2015-02-09 13:55 UTC (History)
1 user (show)

See Also:
cyberbotx: maintainer-feedback+

Attachments
files/patch-fontforge_splinefont.h (392 bytes, patch)
2015-01-24 21:38 UTC, Jan Beich 		no flags Details | Diff
|poudriere testport| log for 8.4R amd64 (234.25 KB, text/plain)
2015-01-24 21:42 UTC, Jan Beich 		no flags Details
|poudriere testport| log for 10.0R amd64 (275.13 KB, text/plain)
2015-01-24 22:52 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-01-24 21:38:02 UTC 
Created attachment 152108 [details]
files/patch-fontforge_splinefont.h

Build on 8.4-RELEASE fails due to lack of base r235785 leading to:

In file included from fontforge.h:37,
                 from fontforgevw.h:30,
                 from fontforgeui.h:32,
                 from activeinui.c:28:
splinefont.h:3561: error: expected ')' before '*' token
splinefont.h:3576: error: expected ')' before '*' token
splinefont.h:3590: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'newlocale_hack'
splinefont.h:3599: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'uselocale_hack'
splinefont.h:3607: error: expected ')' before 'dataset'

http://beefy1.isc.freebsd.org/bulk/84i386-default/latest/logs/errors/fontforge-20141126_1.log
http://beefy2.isc.freebsd.org/bulk/84amd64-default/latest/logs/errors/fontforge-20141126_1.log

In case the hack isn't acceptable let's put:

.if ${OSVERSION} < 900506
BROKEN=		No locale_t support
.endif
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-24 21:38:02 UTC 
Maintainer CC'd
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-01-24 21:42:58 UTC 
Created attachment 152109 [details]
|poudriere testport| log for 8.4R amd64

Added the following line in the patch, so the hack reflects in logs:

  #warning "locale_t support not found, using a hack"
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-01-24 22:25:56 UTC 
Runtime on 8.4R seems to work fine unless the following isn't enough.

$ fontforge /usr/local/lib/X11/fonts/dejavu/DejaVuSans.ttf
Copyright (c) 2000-2014 by George Williams. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Based on sources from 22:14 UTC 24-Jan-2015-ML-NoPython-D.
 Based on source from git with hash:
no xdefs_filename!
TESTING: getPixmapDir:/usr/local/share/fontforge/pixmaps
TESTING: getShareDir:/usr/local/share/fontforge
TESTING: GResourceProgramDir:/usr/local/bin
trying default theme:/usr/local/share/fontforge/pixmaps/resources
else argv[i]:/usr/local/lib/X11/fonts/dejavu/DejaVuSans.ttf
SplineFontPieceMeal() going unhinted...
Comment 4 Jan Beich freebsd_committer freebsd_triage 2015-01-24 22:52:11 UTC 
Created attachment 152110 [details]
|poudriere testport| log for 10.0R amd64
Comment 5 Jan Beich freebsd_committer freebsd_triage 2015-01-24 23:02:53 UTC 
https://reviews.freebsd.org/D1662
Comment 6 Jan Beich freebsd_committer freebsd_triage 2015-01-24 23:04:14 UTC 
Oops, patch-ready may not be set without maintainer-approval.
Comment 7 Naram Qashat 2015-01-25 07:35:02 UTC 
The hack looks fine to me, I'll approve of the patch as well.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-01-25 08:23:00 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Jan 25 08:22:30 UTC 2015
New revision: 377865
URL: https://svnweb.freebsd.org/changeset/ports/377865

Log:
  Unbreak build on 8.x

  PR:		197056
  Differential Revision:	https://reviews.freebsd.org/D1662
  Approved by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)
  Approved by:	bapt (mentor)

Changes:
  head/print/fontforge/files/patch-fontforge_splinefont.h