Bug 197093 - games/angband does not need to specify CPPFLAGS and is in fact broken when it does so
Summary: games/angband does not need to specify CPPFLAGS and is in fact broken when it...
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 14:11 UTC by Chris Nehren
Modified: 2015-06-26 17:55 UTC (History)
1 user (show)

See Also:

Attachments
Fix building against ncurses (342 bytes, text/plain)
2015-01-26 14:11 UTC, Chris Nehren 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nehren 2015-01-26 14:11:49 UTC 
Created attachment 152178 [details]
Fix building against ncurses

The angband source code uses `<ncurses/foo.h>` for all its include files, and this breaks because we're specifying `-I/usr/local/include/ncurses` via CPPFLAGS. This means that none of the ncurses headers are found, and so the GCU backend fails. I've attached a patch that removes the spurious line, and have tested it with both ports and base ncurses.
Comment 1 Bartek Rutkowski freebsd_committer freebsd_triage 2015-05-18 16:47:04 UTC 
I've just tested the port in version 3.5.1 and I cant see any issues with it, as it is. Can you please test on newly installed system (in virtual machine perhaps) and let us know if you still see the original issue? Otherwise, I'll close that PR.
Comment 2 Bartek Rutkowski freebsd_committer freebsd_triage 2015-06-26 17:55:48 UTC 
Since there was no response from the submitter for over two weeks I am closing this PR.