Bug 197134 - emulators/qemu-user-static: 2.2.50.g20150123 update doesn't build on current
Summary: emulators/qemu-user-static: 2.2.50.g20150123 update doesn't build on current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Juergen Lock
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 19:15 UTC by Dmitry Marakasov
Modified: 2015-01-27 21:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nox)


Attachments
Failure log (68.94 KB, text/plain)
2015-01-27 19:15 UTC, Dmitry Marakasov
no flags Details
Add check for a reaper definition (1.01 KB, patch)
2015-01-27 19:58 UTC, Juergen Lock
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2015-01-27 19:15:26 UTC
Created attachment 152266 [details]
Failure log

Subj, previous version (2.2.50.g20150106) built fine.

System: FreeBSD 11.0-CURRENT r275712 amd64

Error:

/usr/work/usr/ports/emulators/qemu-user-static/work/seanbruno-qemu-bsd-user-0dbb545/bsd-user/freebsd/os-proc.c:411:23: error: incomplete definition of type 'struct procctl_reaper_kill'
    __get_user(host_rk->rk_flags, &target_rk->rk_flags);
               ~~~~~~~^
/usr/work/usr/ports/emulators/qemu-user-static/work/seanbruno-qemu-bsd-user-0dbb545/bsd-user/qemu.h:363:9: note: expanded from macro '__get_user'
        x = (typeof(*hptr))tswap16(*(uint16_t *)(hptr));\
        ^
/usr/work/usr/ports/emulators/qemu-user-static/work/seanbruno-qemu-bsd-user-0dbb545/bsd-user/freebsd/os-proc.c:404:50: note: forward declaration of 'struct procctl_reaper_kill'
t2h_reaper_kill(abi_ulong target_rk_addr, struct procctl_reaper_kill *host_rk)
                                                 ^
Full log attached.
Comment 1 Bugzilla Automation freebsd_committer 2015-01-27 19:15:26 UTC
Auto-assigned to maintainer nox@FreeBSD.org
Comment 2 Juergen Lock freebsd_committer 2015-01-27 19:35:25 UTC
Hmm is this an older head that doesn't have the reaper stuff yet?  If yes we might need to fix a __FreeBSD_version check.  sson, you are running head right?
Comment 3 Juergen Lock freebsd_committer 2015-01-27 19:58:18 UTC
Created attachment 152272 [details]
Add check for a reaper definition

Can you test this patch?

Thanx! :)
Juergen
Comment 4 Dmitry Marakasov freebsd_committer 2015-01-27 20:59:30 UTC
Confirmed, the patch fixes the build.
Comment 5 commit-hook freebsd_committer 2015-01-27 21:33:18 UTC
A commit references this bug:

Author: nox
Date: Tue Jan 27 21:33:14 UTC 2015
New revision: 378022
URL: https://svnweb.freebsd.org/changeset/ports/378022

Log:
  Fix bsd-user build on older head that doesn't have the reaper stuff yet.

  PR:		197134
  Submitted by:	amdmi3

Changes:
  head/emulators/qemu-sbruno/files/patch-bsd-user-freebsd-os-proc.c
Comment 6 Juergen Lock freebsd_committer 2015-01-27 21:34:21 UTC
Committed.  Thanks!