Bug 197167 - devel/protobuf: add armv6 to supported architecture
Summary: devel/protobuf: add armv6 to supported architecture
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 09:57 UTC by Mikael Urankar
Modified: 2015-02-21 08:45 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
armv6 fix (2.01 KB, patch)
2015-01-29 09:57 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2015-01-29 09:57:43 UTC
Created attachment 152331 [details]
armv6 fix

Hi,

protobuf works fine on armv6 with the attached patch.

Use the 'internal atomic implementation' on armv6.
Import upstream patch to fix a bug in the 'internal atomic operation':
https://github.com/google/protobuf/commit/cc0a047384414991009d95ada9e89b9a92aac531

build log:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/protobuf-2.6.0.log
Comment 1 Bugzilla Automation freebsd_committer 2015-01-29 09:57:43 UTC
Auto-assigned to maintainer sunpoet@FreeBSD.org
Comment 2 commit-hook freebsd_committer 2015-02-21 08:39:42 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Feb 21 08:38:45 UTC 2015
New revision: 379486
URL: https://svnweb.freebsd.org/changeset/ports/379486

Log:
  - Fix build with armv6

  PR:		197167
  Submitted by:	<mikael.urankar@gmail.com>
  Obtained from:	https://github.com/google/protobuf/commit/cc0a047384414991009d95ada9e89b9a92aac531

Changes:
  head/devel/protobuf/Makefile
  head/devel/protobuf/files/
  head/devel/protobuf/files/patch-src-google-protobuf-stubs-atomicops.h
  head/devel/protobuf/files/patch-src-google-protobuf-stubs-atomicops_internals_generic_gcc.h
Comment 3 Po-Chuan Hsieh freebsd_committer 2015-02-21 08:45:39 UTC
Committed. Thanks!