Bug 197172 - security/john: corrupted config file
Summary: security/john: corrupted config file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 12:34 UTC by Vladimir Gusev
Modified: 2017-01-27 07:33 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
john default config file (40.33 KB, text/plain)
2015-01-29 12:34 UTC, Vladimir Gusev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Gusev 2015-01-29 12:34:58 UTC
Created attachment 152334 [details]
john default config file

Once successfully installed from ports, 

make -C /usr/ports/security/john/ install clean

john couldn't open its config file:

[root@portal ~]# john passwd.txt 
fopen: $JOHN/john.local.conf: No such file or directory

[root@portal ~]# ll /usr/local/etc/john*
-rw-r--r--  1 root  wheel  41299 Jan 29 15:14 /usr/local/etc/john.conf
-rw-r--r--  1 root  wheel  41299 Jan 29 15:14 /usr/local/etc/john.conf.default

Troubleshooting performed leads to a deeper problem:

[root@portal ~]# export JOHN=/usr/local/etc
[root@portal ~]# ln -s /usr/local/etc/john.conf /usr/local/etc/john.local.conf
[root@portal ~]# john passwd.txt 
ERROR, .include recursion too deep in john.ini processing file .include "$JOHN/dumb16.conf"
Error in /usr/local/share/john/john.local.conf at line 1606
[root@portal ~]# find / -type f -name "*dumb16.conf*"
/usr/local/share/john/dumb16.conf

=================================
 - FreeBSD 10.1-RELEASE-p4 amd64
 - the latest ports tree
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-29 12:34:58 UTC
Auto-assigned to maintainer danfe@FreeBSD.org
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-01 10:27:48 UTC
Thank you for reporting it; I'm currently in process of upgrading JtR to version 1.8.0, and will take care of this issue as well.
Comment 3 Vijay 2015-08-23 11:54:14 UTC
I have the exact same issue.. is there an workaround for this bug, while you are working to upgrade to 1.80??
Comment 4 Maxim Filimonov 2015-12-10 18:41:35 UTC
Is there any progress on this issue?
Comment 5 Maxim Filimonov 2015-12-10 18:56:40 UTC
By the way, there _is_ a workaround. You just `touch /usr/local/share/john/john.local.conf`, and everything is fine.
Comment 6 Gavin Atkinson freebsd_committer freebsd_triage 2016-07-22 09:53:53 UTC
This is still an issue...
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2016-07-22 16:15:22 UTC
(In reply to Gavin Atkinson from comment #6)

Yes, it is.  I'm working on a big port update, stay tuned.  Sorry for all the delays...
Comment 8 Ben Woods freebsd_committer freebsd_triage 2016-09-24 14:57:09 UTC
Hi everyone, I have also prepared a patch to update security/john to 1.8.0-jumbo-1, and I believe this problem no longer exists after the update.
https://reviews.freebsd.org/D7955

Could people please apply the patch from that link and test if the conf file error still occurs?

Thanks,
Ben
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-11-12 15:17:03 UTC
A commit references this bug:

Author: danfe
Date: Sat Nov 12 15:16:57 UTC 2016
New revision: 425958
URL: https://svnweb.freebsd.org/changeset/ports/425958

Log:
  - Update `security/john' to 1.8.0-jumbo-1 (long overdue)
  - Remove no longer needed build-related logic since they moved to GNU
    autotools' based build
  - Disable OPENMP option for the moment; it will be reintroduced with
    others (e.g. OpenCL) in a separate commit
  - Add upstream patch to fix the build on non-x86 architectures [2]
  - Do not define _POSIX_SOURCE when compiling wordlist.c: this results
    in broken JtR binary at least on i386
  - Define JOHN_SYSTEMWIDE_EXEC for the future when we start to provide
    fall-back binaries
  - Stop moving john.conf to /etc.  We're not doing it for other *.conf
    files anyway (the include files); JtR is smart enough to locate its
    configuration files properly when built in system-wide mode [1]
  - Install full set of documentation files included with -jumbo
  - Remove `xtract' symlink which hasn't been part of JtR for more than
    a decade; install more useful symlinks (unafs, unique, other un* and
    *2john) that were added in -jumbo instead
  - Previously *.pl, *.rb, and *.py scripts were installed into DATADIR;
    Alexander wanted to see them along with the documentation, but that
    goes a bit too far; put them in ${DATADIR}/extra for the time being

  PR:		197172 [1]
  Obtained from:	http://www.openwall.com/lists/john-dev/2014/12/18/21 [2]

Changes:
  head/security/john/Makefile
  head/security/john/distinfo
  head/security/john/files/patch-rawSHA0__fmt__plug.c
  head/security/john/files/patch-src_john.c
  head/security/john/files/patch-src_params.h
  head/security/john/files/patch-src_rawSHA0__fmt.c
  head/security/john/files/patch-truecrypt__fmt__plug.c
  head/security/john/files/patch-wordlist.c
  head/security/john/pkg-plist
Comment 10 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-01-27 07:33:07 UTC
Assume fixed as of ports r425958 due to lack of feedback.