Bug 197231 - math/openblas: [PATCH] update to 0.2.13
Summary: math/openblas: [PATCH] update to 0.2.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-01 00:59 UTC by Johannes M Dieterich
Modified: 2015-02-01 17:33 UTC (History)
2 users (show)

See Also:
phd_kimberlite: maintainer-feedback+


Attachments
svn diff math/openblas (2.02 KB, patch)
2015-02-01 00:59 UTC, Johannes M Dieterich
no flags Details | Diff
poudriere log (compressed) (258.40 KB, application/octet-stream)
2015-02-01 06:26 UTC, Eijiro Shibusawa
phd_kimberlite: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes M Dieterich freebsd_committer 2015-02-01 00:59:25 UTC
Created attachment 152427 [details]
svn diff math/openblas

Minor update to 0.2.13, some select important updates from http://www.openblas.net/Changelog.txt:

* Fix Fortran compiler detection on FreeBSD.
	  (#470, Thanks Mike Nolta)
* Fix a bug of sgemm kernel on Intel Sandy Bridge.
* Added CBLAS interface for ?omatcopy and ?imatcopy.
* Improved axpy and symv performance on AMD Bulldozer.
* Improved gemv performance on modern Intel and AMD CPUs.

portlint reports two warnings:

WARN: Makefile: QUAD_PRECISION appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.

WARN: Makefile: DEBUG appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.

but these existed in the 0.2.11 port as well, hence are no regressions.
Comment 1 Bugzilla Automation freebsd_committer 2015-02-01 00:59:25 UTC
Maintainer CC'd
Comment 2 Eijiro Shibusawa 2015-02-01 06:26:03 UTC
Created attachment 152431 [details]
poudriere log (compressed)

Hi, Mr. reporter.

I approve your patch.
The patch has been tested on my poudriere, and the log is attached.
Please commit the patch.

Best regards, Shibusawa
Comment 3 Thierry Thomas freebsd_committer 2015-02-01 14:21:40 UTC
Approved by maintainer.
Comment 4 commit-hook freebsd_committer 2015-02-01 15:35:28 UTC
A commit references this bug:

Author: thierry
Date: Sun Feb  1 15:35:16 UTC 2015
New revision: 378246
URL: https://svnweb.freebsd.org/changeset/ports/378246

Log:
  Minor update to 0.2.13, some select important updates from
  http://www.openblas.net/Changelog.txt:

  * Fix Fortran compiler detection on FreeBSD.
  	  (#470, Thanks Mike Nolta)
  * Fix a bug of sgemm kernel on Intel Sandy Bridge.
  * Added CBLAS interface for ?omatcopy and ?imatcopy.
  * Improved axpy and symv performance on AMD Bulldozer.
  * Improved gemv performance on modern Intel and AMD CPUs.

  PR:		ports/197231
  Submitted by:	dieterich.joh (at) gmail.com
  Approved by:	phd_kimberlite (at) yahoo.co.jp (maintainer)

Changes:
  head/math/openblas/Makefile
  head/math/openblas/distinfo
  head/math/openblas/files/patch-c_check
Comment 5 Thierry Thomas freebsd_committer 2015-02-01 15:36:55 UTC
Committed, thanks!

Note: have you tried to make it compile with clang?
Comment 6 Johannes M Dieterich freebsd_committer 2015-02-01 16:34:55 UTC
No, as the port ships with a Fortran interface, hence needs gfortran anyway.
Comment 7 Thierry Thomas freebsd_committer 2015-02-01 17:33:10 UTC
Not at all: many ports use fortran but not Gcc!
E.g. see math/lapack (and math/blas).