Bug 197241 - [PATCH] sysutils/lsof fix build on systems without /etc/make.conf
Summary: [PATCH] sysutils/lsof fix build on systems without /etc/make.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-01 13:31 UTC by Thomas Zander
Modified: 2018-10-01 14:05 UTC (History)
2 users (show)

See Also:
ler: maintainer-feedback+


Attachments
Patch to fix build on systems without /etc/make.conf (920 bytes, text/plain)
2015-02-01 13:31 UTC, Thomas Zander
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer 2015-02-01 13:31:49 UTC
Created attachment 152436 [details]
Patch to fix build on systems without /etc/make.conf

Terry Kennedy <terry@tmk.com> noticed that on plain vanilla installations of FreeBSD lsof does not build due to picking up CFLAGS incorrectly.

We tracked this down to a bug in lsof's configure script checking for the existence of make.conf and then deriving CFLAGS based on the result.
It turns out that it does not do anything with make.conf's content, but its absence causes the configure script to select CFLAGS erroneously.
The attached micro-patch ensures that the same algorithm is always used to select CFLAGS, independently of make.conf's existence on the target machine.

Tested on 8.4, 9.3 (i386) and 10.1 (amd64, armv6).

@Maintainer: Do you approve?
Comment 1 Bugzilla Automation freebsd_committer 2015-02-01 13:31:49 UTC
Maintainer CC'd
Comment 2 Larry Rosenman freebsd_committer 2015-02-01 14:08:07 UTC
looks reasonable to me -- I will also forward to Vic for inclusion in the next release/fixup.
Comment 3 commit-hook freebsd_committer 2015-02-01 15:27:26 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb  1 15:27:14 UTC 2015
New revision: 378245
URL: https://svnweb.freebsd.org/changeset/ports/378245

Log:
  Fix build on systems without /etc/make.conf

  PR:		197241
  Submitted by:	riggs
  Approved by:	ler@lerctr.org (maintainer)
  MFH:		2015Q1

Changes:
  head/sysutils/lsof/files/
  head/sysutils/lsof/files/patch-Configure
Comment 4 Thomas Zander freebsd_committer 2015-02-01 15:28:48 UTC
Thanks for the quick response!
Comment 5 commit-hook freebsd_committer 2015-02-01 15:49:32 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb  1 15:48:58 UTC 2015
New revision: 378249
URL: https://svnweb.freebsd.org/changeset/ports/378249

Log:
  MFH: r378245

  Fix build on systems without /etc/make.conf

  PR:		197241
  Submitted by:	riggs
  Approved by:	ports-secteam (zi), ler@lerctr.org (maintainer)

Changes:
_U  branches/2015Q1/
  branches/2015Q1/sysutils/lsof/Makefile
  branches/2015Q1/sysutils/lsof/files/
Comment 6 commit-hook freebsd_committer 2018-10-01 14:02:46 UTC
A commit references this bug:

Author: arrowd
Date: Mon Oct  1 14:02:08 UTC 2018
New revision: 481032
URL: https://svnweb.freebsd.org/changeset/ports/481032

Log:
  lang/ghc: Disable using xelatex, as the build fails if it is present.

  PR:		197241
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>
  Approved by:	tcberner (mentor)

Changes:
  head/lang/ghc/Makefile
Comment 7 Gleb Popov freebsd_committer 2018-10-01 14:05:43 UTC
Oops, I put wrong ID in my commit message. Sorry for the noise.