Bug 197275 - [patch] mail/dovecot2 startup script noise fix
Summary: [patch] mail/dovecot2 startup script noise fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 16:47 UTC by Kurt Jaeger
Modified: 2015-02-02 17:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments
patch (714 bytes, patch)
2015-02-02 16:47 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2015-02-02 16:47:39 UTC
Created attachment 152487 [details]
patch

As discussed in the mailthread

https://lists.freebsd.org/pipermail/freebsd-ports/2015-February/097905.html

the /usr/local/etc/rc.d/dovecot startup script displays noise on startup
if dovecot is installed but not set up.

The patch avoids the noise (hopefully without side effects).
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-02 16:47:39 UTC
Auto-assigned to maintainer adamw@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-02-02 17:17:05 UTC
A commit references this bug:

Author: adamw
Date: Mon Feb  2 17:16:13 UTC 2015
New revision: 378311
URL: https://svnweb.freebsd.org/changeset/ports/378311

Log:
  rc.d/dovecot allows for multiple concurrent dovecot setups, but in doing
  so runs the dovecot binary against each provided configuration file to
  obtain configuration data. When the configuration file doesn't exist, it
  says:
  	doveconf: Fatal: open(/im_not_here) failed: No such file or directory

  Mistyping the conf file locations when doing multiple instances deserves
  an error message. The real issue here is that in order to set up
  dovecot, you have to actually copy files over from ${EXAMPLESDIR}. The
  default configuration file intentionally does not exist in a clean
  installation. So everybody who installs the dovecot2 port and does not
  configure it will receive that message at every boot.

  Fix it with a patch from pi that makes sure the conf file exists before
  trying to do stuff with it.

  PORTREVISION bump.

  PR:		197275
  Submitted by:	pi

Changes:
  head/mail/dovecot2/Makefile
  head/mail/dovecot2/files/dovecot.in
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2015-02-02 17:19:48 UTC
Thanks, Kurt! I've committed this patch.

That multiple-instances stuff was in there when I inherited the port. Is running multiple instances of dovecot a common thing to do? I definitely don't see other ports doing it...

Dovecot lets you set up multiple listeners with per-listener and per-user behaviours, so I'm not sure how useful this is.

I'm interested in any thoughts you have here...
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-02 17:28:01 UTC
Multi-instance setups should become the norm for every kind of daemon, but I have not used it for dovecot yet 8-}