Bug 197374 - net/krdc generates invalid syntax calling xfreerdp
Summary: net/krdc generates invalid syntax calling xfreerdp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-06 15:03 UTC by amvandemore
Modified: 2015-02-21 21:23 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description amvandemore 2015-02-06 15:03:22 UTC
This is what krdc tries to run:

krdc(89832)/krdc (RDP backend) RdpView::start: Starting xfreerdp with arguments: ("-g", "1024x768", "-k", "0x00000409", "-d", "stp01", "-u", "xxx", "-p", "xxx", "-D", "-X", "14680187", "-a", "16", "--plugin", "rdpsnd", "--plugin", "rdpdr", "--data", "disk:media:/media", "--", "-x", "l", "--rfx", "--ignore-certificate", "--plugin", "cliprdr", "-t", "3389", "10.21.0.72")

This syntax is missing the rdpsnd plugin data type eg "--data alsa".  AFAIK this option should appear after "--plugin rdpsnd" and before "--plugin rdpdr"

Perhaps this is an upstream issue, but I'm not able to confirm that ATM.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-02-08 04:52:46 UTC
Fix Summary and assign.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-02-20 09:33:04 UTC
Can you test if area51 r10593 fixes the problem for you?
Comment 3 amvandemore 2015-02-21 16:09:20 UTC
Much better, thanks.
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-02-21 19:45:09 UTC
Max, can you please land the patch into the ports tree then?
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-02-21 21:09:20 UTC
A commit references this bug:

Author: makc
Date: Sat Feb 21 21:08:26 UTC 2015
New revision: 379551
URL: https://svnweb.freebsd.org/changeset/ports/379551

Log:
  net/krdc:
  - Add patch from upstream for FreeRDP 1.1+ support

  PR:		197374
  Reported by:	amvandemore@gmail.com

Changes:
  head/net/krdc/Makefile
  head/net/krdc/files/patch-git8436cc62
Comment 6 Max Brazhnikov freebsd_committer freebsd_triage 2015-02-21 21:23:14 UTC
Fixed, thanks for report!