Bug 197383 - [MAINTAINER] games/wxlauncher: Update to 0.9.5
Summary: [MAINTAINER] games/wxlauncher: Update to 0.9.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-02-07 02:05 UTC by lightside
Modified: 2015-02-23 00:29 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 374599 revision) (1.99 KB, patch)
2015-02-07 02:05 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (88.17 KB, text/plain)
2015-02-07 02:06 UTC, lightside
no flags Details
Proposed patch (since 374599 revision) (2.92 KB, patch)
2015-02-07 03:54 UTC, lightside
koobs: maintainer-approval+
Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (9.09 KB, application/x-bzip2)
2015-02-07 03:55 UTC, lightside
no flags Details
The poudriere testport log (FreeBSD 10 amd64, with WX3 option enabled) (10.12 KB, application/x-bzip2)
2015-02-07 04:59 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2015-02-07 02:05:49 UTC
Created attachment 152649 [details]
Proposed patch (since 374599 revision)

Patch to update games/wxlauncher port from 0.9.4 to 0.9.5 version.

Look following link for changes:
https://github.com/wxLauncher/wxlauncher/compare/release-0.9.4...release-0.9.5

This version introduces wxWidgets 3.0 support, but its string routines is broken in case of games/diaspora port, therefore the check for wxWidgets 3.0 was removed from CMakeLists.txt file.
Comment 1 lightside 2015-02-07 02:06:23 UTC
Created attachment 152650 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 2 lightside 2015-02-07 03:54:10 UTC
Created attachment 152653 [details]
Proposed patch (since 374599 revision)

The application, built in debug mode (WANT_DEBUG=yes) and run with gdb, shows following stack trace:
-8<--
(gdb) run
Starting program: /usr/local/bin/wxlauncher 
[New LWP 100287]
[New Thread 816806400 (LWP 100287/wxlauncher)]
/usr/local/include/wx-3.0/wx/strvararg.h(456): assert "(argtype & (wxFormatStringSpecifier<T>::value)) == argtype" failed in wxArgNormalizer(): format specifier doesn't match argument type

Program received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread 816806400 (LWP 100287/wxlauncher)]
0x000000080355626a in thr_kill () from /lib/libc.so.7
(gdb) bt
#0  0x000000080355626a in thr_kill () from /lib/libc.so.7
#1  0x00000008010bed56 in wxGUIAppTraits::ShowAssertDialog () from /usr/local/lib/libwx_gtk2u_core-3.0.so.0
#2  0x0000000800a58e9e in wxAppConsoleBase::OnAssertFailure () from /usr/local/lib/libwx_baseu-3.0.so.0
#3  0x0000000800a58b2a in wxAppConsoleBase::OnAssertFailure () from /usr/local/lib/libwx_baseu-3.0.so.0
#4  0x000000080109c5f5 in wxApp::OnAssertFailure () from /usr/local/lib/libwx_gtk2u_core-3.0.so.0
#5  0x0000000800a59417 in wxAbort () from /usr/local/lib/libwx_baseu-3.0.so.0
#6  0x0000000800a57caf in wxOnAssert () from /usr/local/lib/libwx_baseu-3.0.so.0
#7  0x000000000047c431 in wxArgNormalizer (this=0x7fffffffb6b8, value=0, fmt=0x7fffffffc0c0, index=1)
    at strvararg.h:456
#8  0x000000000047c396 in wxArgNormalizerWchar (this=0x7fffffffb6b8, value=0, fmt=0x7fffffffc0c0, index=1)
    at strvararg.h:476
#9  0x000000000047c32b in wxArgNormalizerWchar (this=0x7fffffffb6b8, value=0, fmt=0x7fffffffc0c0, index=1)
    at strvararg.h:476
#10 0x000000000047b70b in wxString::Format<unsigned long> (f1=@0x7fffffffc0c0, a1=0) at string.h:2322
#11 0x00000000004cddac in ProMan::Initialize (flags=ProMan::None)
    at /usr/ports/games/wxlauncher/work/wxLauncher-wxlauncher-7ee46df/code/apis/ProfileManager.cpp:145
#12 0x0000000000516894 in wxLauncher::OnInit (this=0x81691f080)
    at /usr/ports/games/wxlauncher/work/wxLauncher-wxlauncher-7ee46df/code/wxLauncherApp.cpp:219
#13 0x0000000000517de9 in wxAppConsoleBase::CallOnInit (this=0x81691f080) at app.h:93
#14 0x0000000800abf298 in wxEntry () from /usr/local/lib/libwx_baseu-3.0.so.0
#15 0x0000000000513f96 in main (argc=1, argv=0x7fffffffd8b0)
    at /usr/ports/games/wxlauncher/work/wxLauncher-wxlauncher-7ee46df/code/wxLauncherApp.cpp:50
-->8-

It might be related to wxLogInfo format specifiers.

It is possible to ignore such assertion errors, because the application works. So, I decided to create a patch with selection of wxWidgets version and 2.8 by default. In case of 3.0 version it will be possible to debug such application and submit patch(es), which fixes such errors, for interested people.
Comment 3 lightside 2015-02-07 03:55:48 UTC
Created attachment 152654 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 4 lightside 2015-02-07 04:29:58 UTC
Looks like, the 0.9.5 version marked as pre-release on GitHub. The latest release is 0.9.4 version.
Beside of wxWidgets 3.0 support, the 0.9.5 version fixes other bugs and works ok for wxWidgets 2.8 version (e.g. without assertion errors). But I'm not sure, if it need to be commited. Maybe, to support development, in case of other interested people.
Comment 5 lightside 2015-02-07 04:59:52 UTC
Created attachment 152658 [details]
The poudriere testport log (FreeBSD 10 amd64, with WX3 option enabled)
Comment 6 lightside 2015-02-07 05:15:28 UTC
(In reply to comment #4)
Now, the 0.9.5 version marked as latest release:
https://github.com/wxLauncher/wxlauncher/releases/tag/release-0.9.5

Excerpt from current description:
"A quick release with support for wxWidgets 2.8, wxWidgets 2.8 STL, and wxWidgets 3.0."
Comment 7 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-02-23 00:27:00 UTC
Take
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-23 00:29:09 UTC
A commit references this bug:

Author: rm
Date: Mon Feb 23 00:28:44 UTC 2015
New revision: 379636
URL: https://svnweb.freebsd.org/changeset/ports/379636

Log:
  games/wxlauncher: update to 0.9.5

  PR:		197383
  Submitted by:	lightside@gmx.com (maintainer)

Changes:
  head/games/wxlauncher/Makefile
  head/games/wxlauncher/distinfo
Comment 9 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-02-23 00:29:29 UTC
Committed, thank you.