Bug 197419 - deskutils/mirall: Update to version 1.7.1
Summary: deskutils/mirall: Update to version 1.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-08 18:45 UTC by tkato432
Modified: 2015-02-09 20:35 UTC (History)
1 user (show)

See Also:


Attachments
deskutils_mirall.diff (16.65 KB, patch)
2015-02-08 18:45 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-02-08 18:45:11 UTC
Created attachment 152718 [details]
deskutils_mirall.diff
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2015-02-09 09:41:27 UTC
Hi,

This update works well in poudriere, but I've been able to make it compile and run on my systems from ports.

It fails to compile with this error:

/usr/ports/deskutils/mirall/work/mirall-1.7.1/src/mirall/propagator_legacy.cpp:102:16: error: no member named
      'oc_header_modtime' in 'hbf_transfer_s'
        trans->oc_header_modtime = FileSystem::getModTime(file.fileName());
        ~~~~~  ^
/usr/ports/deskutils/mirall/work/mirall-1.7.1/src/mirall/propagator_legacy.cpp:114:37: error: no member named
      'oc_header_modtime' in 'hbf_transfer_s'
            _item._modtime = trans->oc_header_modtime;
                             ~~~~~  ^
/usr/ports/deskutils/mirall/work/mirall-1.7.1/src/mirall/propagator_legacy.cpp:194:56: error: no member named
      'oc_header_modtime' in 'hbf_transfer_s'
            if (!updateMTimeAndETag(uri.data(), trans->oc_header_modtime))
                                                ~~~~~  ^
/usr/ports/deskutils/mirall/work/mirall-1.7.1/src/mirall/propagator_legacy.cpp:251:60: error: no member named
      'oc_header_modtime' in 'hbf_transfer_s'
        pi._modtime =  Utility::qDateTimeFromTime_t(trans->oc_header_modtime);
                                                    ~~~~~  ^
12 warnings and 4 errors generated.


(full log available here: http://www.madpilot.net/~mad/mirall.log, made with MAKE_JOBS disabled to keep it cleaner)

I've been unable to find a cause for this, do you have an idea why this is happening?

Thanks!
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2015-02-09 09:57:04 UTC
(In reply to Guido Falsi from comment #1)

Answering to myself, I now understand what is happening. If the old version of mirall is installed that source file finds the old version of an include file before the one it wants.

So I need to tweak the order of include directories to fix this, or every user upgrading via ports will meet this problem.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2015-02-09 20:34:37 UTC
Committed, with minor changes.

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-09 20:35:15 UTC
A commit references this bug:

Author: madpilot
Date: Mon Feb  9 20:34:19 UTC 2015
New revision: 378751
URL: https://svnweb.freebsd.org/changeset/ports/378751

Log:
  - Update to 1.7.1
  - Reword COMMENT

  PR:		197419
  Submitted by:	tkato432@yahoo.com

Changes:
  head/deskutils/mirall/Makefile
  head/deskutils/mirall/distinfo
  head/deskutils/mirall/files/patch-src__CMakeLists.txt
  head/deskutils/mirall/files/patch-src__mirall__accountsettings.cpp
  head/deskutils/mirall/files/patch-src__mirall__filesystem.cpp
  head/deskutils/mirall/files/patch-src__mirall__owncloudgui.cpp
  head/deskutils/mirall/pkg-plist