Bug 197483 - [arm] www/webkit-qt5 needs patch for FreeBSD CacheFlush Support
Summary: [arm] www/webkit-qt5 needs patch for FreeBSD CacheFlush Support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-09 15:47 UTC by Sean Bruno
Modified: 2015-02-21 20:17 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (kde)


Attachments
fix build on armv6 (576 bytes, patch)
2015-02-09 18:53 UTC, Mikael Urankar
no flags Details | Diff
Functionally the same patch, but change tabs to spaces. (535 bytes, patch)
2015-02-21 18:58 UTC, Sean Bruno
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer 2015-02-09 15:47:54 UTC
Yet another port that needs a patch to support FreeBSD CacheFlush instructions on ARM.

I'll get to this unless someone snaps it up and does the patch for it.

Logs here:

http://chips.ysv.freebsd.org/data/11armv6-11armv6/2015-02-06_22h08m16s/logs/errors/qt5-webkit-5.3.2_2.log

...
In file included from /wrkdirs/usr/ports/www/webkit-qt5/work/qtwebkit-opensource-src-5.3.2/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:33:
/wrkdirs/usr/ports/www/webkit-qt5/work/qtwebkit-opensource-src-5.3.2/Source/JavaScriptCore/assembler/ARMAssembler.h:1073:2: error: "The cacheFlush support is missing on this platform."
#error "The cacheFlush support is missing on this platform."
...
Comment 1 Bugzilla Automation freebsd_committer 2015-02-09 15:47:54 UTC
Auto-assigned to maintainer kde@FreeBSD.org
Comment 2 Mikael Urankar freebsd_committer 2015-02-09 18:53:08 UTC
Created attachment 152815 [details]
fix build on armv6

The attached patch adds the CacheFlush instructions on ARM.

build log (not a poudriere one):
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/qt5-webkit-5.3.2_2.log
Comment 3 Sean Bruno freebsd_committer 2015-02-09 19:25:07 UTC
Test build running.  It'll be a bit.

http://tasty.ysv.freebsd.org/build.html?mastername=11mips64-default&build=2015-02-09_19h15m14s
Comment 4 Raphael Kubo da Costa freebsd_committer 2015-02-15 22:03:13 UTC
No objections from kde@ other than you should use spaces instead of tabs in your patch. Also, are you going to submit this upstream?
Comment 5 Sean Bruno freebsd_committer 2015-02-16 00:00:39 UTC
(In reply to Raphael Kubo da Costa from comment #4)

ok, we'll fix the tabs/spaces thing.

We were hoping that kde@ could upstream this and have not posted it anywhere except to this bug report.
Comment 6 Raphael Kubo da Costa freebsd_committer 2015-02-16 20:03:02 UTC
While it's certainly possible for me to send it upstream, for example, I believe it makes more sense for the people who actually wrote the code to do that: I, for one, have no idea what the code does, what it is supposed to implement and argue for its inclusion.
Comment 7 Sean Bruno freebsd_committer 2015-02-16 20:05:02 UTC
(In reply to Raphael Kubo da Costa from comment #6)
Sure.  I understand.  Where and how do I report this?  e.g. a bugzilla or tracker instance?
Comment 8 Raphael Kubo da Costa freebsd_committer 2015-02-16 22:11:44 UTC
The contribution guidelines are described here: http://qt-project.org/wiki/Qt-Contribution-Guidelines

The TL;DR version is that you're supposed to:
1) Accept Qt's contribution agreement (once)
2) Send your patch through Gerrit targeting the current stable branch (5.4 at the moment) since it's a bug fix.
3) CC one or more people to review your change (you can also CC me in Gerrit).

Please let me know if you have any problems or need more information.
Comment 9 Sean Bruno freebsd_committer 2015-02-17 21:30:41 UTC
(In reply to Raphael Kubo da Costa from comment #8)
Fired off a jira issue/bug thing:

https://bugreports.qt.io/browse/QTBUG-44525
Comment 10 Raphael Kubo da Costa freebsd_committer 2015-02-17 21:44:37 UTC
Qt only accepts patches submitted via Gerrit, since you also have to accept its contributor agreement. Can you send your patch through Gerrit and mention the bug report you opened ("Task-number: QTBUG-XXX")?
Comment 11 Sean Bruno freebsd_committer 2015-02-21 18:58:24 UTC
Created attachment 153286 [details]
Functionally the same patch, but change tabs to spaces.
Comment 12 commit-hook freebsd_committer 2015-02-21 19:06:58 UTC
A commit references this bug:

Author: sbruno
Date: Sat Feb 21 19:06:12 UTC 2015
New revision: 379541
URL: https://svnweb.freebsd.org/changeset/ports/379541

Log:
  Add support for armv6 by adding __clear_cache support to ASM in the javascript
  assembler.  This mirrors similar patches to other webkit ports.

  PR:		197483
  Submitted by:	mikael.urankar@gmail.com
  Reviewed by:	rakuco@FreeBSD.org (for kde@)

Changes:
  head/www/webkit-qt5/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h
Comment 13 commit-hook freebsd_committer 2015-02-21 20:17:09 UTC
A commit references this bug:

Author: rakuco
Date: Sat Feb 21 20:16:22 UTC 2015
New revision: 379547
URL: https://svnweb.freebsd.org/changeset/ports/379547

Log:
  Fix `make patch' after r379541.

  The new patch just didn't apply, and apparently nobody tested it before
  committing...

  PR:		197483

Changes:
  head/www/webkit-qt5/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h