Created attachment 152835 [details] Patch to update audio/tomahawk to 0.8.2 - Update to 0.8.2 - Remove patch/patch-CMakeModules__FindCLucene.cmake, patch/patch-src_libtomahawk_utils_TomahawkUtils.cpp.orig, patch/patch-src__main.cpp - Add patch/patch-src_libtomahawk_utils_TomahawkUtils.cpp - Add devel/google-sparsehash, security/gnutls, and security/qtkeychain to dependencies - Use textproc/luceneplusplus instead of textproc/clucene as library dependency - Build a release distribution to disable debug and test tools - Sort variables - Remove XINE option because the relative phonon backend is not supported - Use vlc as default phonon backend, because the gstreamer one gives the error: "GStreamer-CRITICAL **: gst_mini_object_unref: assertion `mini_object->refcount > 0' failed" at runtime - Add option HATCHET (default ON) to enable hatchet plugin (see https://hatchet.is ) - Use option helpers
Auto-assigned to maintainer arved@FreeBSD.org
Hi Nicola, Thanks for your work. I also started a patch, but i was struggling with audio output so i did not complete it yet. I have not tested it yet and just compared your patch with mine and i have two questions: - Can you check if the qtweetlib option is still relevant? I think the dependency has been removed because it is referenced nowhere in the sourcecode or documentation anymore - websocketpp is just header files so adding it as a runtime dependency looks wrong. Since i am not sure i will be able to test it in the next time, - Did you build test it? (I needed a lot more patches to the cmake files, see github pullrequest 280 for details) - Did audio output work for you?
Hi Tilman, you are right: Qtweetlib is no longer required and websocketpp is only a build dependency. I built the port on FreeBSD-10 amd64 with poudriere, here is the full log: http://people.freebsd.org/~nivit/logs/tomahawk-0.8.2.log. About the audio output: with phonon-gstreamer backend there's no audio, and appears the error message said before. With phonon-vlc backend all works fine. P.S. Maybe we have to add also another option to support Telepathy via net-im/telepathy-qt4?
Hi, I just saw your pullrequest on github. I don't know, maybe adding -I${LOCALBASE}/include to CXXFLAGS solves the problem with attica includes...
Tested your version. I noticed that gstreamer might be used if it is installed even if vlc is selected in make config. I am currently thinking about removing the gstreamer option or marking it as broken and adding a pkg-message to warn people of broken phonon-gstreamer. I agree adding a dependency on telepathy-qt4 might be a good idea.
(In reply to Tilman Keskinoz from comment #5) Indeed , if you have also installed phonon-gstreamer, then there is no audio. A possible workaround is to launch tomahawk with the following command: $ env PHONON_BACKEND=phonon_vlc tomahawk Maybe you could add it in pkg-message. I agree with you to remove/mark broken gstreamer option.
Just to follow up on this. I don't have much time to work on this. Other issues that came up so far: 1. google_sparsehash is also a header only port, so only a BUILD_DEPENDS is necessary 2. telepathy-qt4 is autodected if installed. affects also plist 3. the CMAKE_BUILD_TYPE expansion in pkg-plist creates pkg-plist issues with WITH_DEBUG is specified 4. There are still some segfaults for me. so stay tuned...
Created attachment 154229 [details] Current state of patch as of 2015-03-11 Add my current wip patch Changes: - Removed the HATCHET option, as it is just one builddep - Removed VLC option and made it a rundep - Add TELEPATHY option (Not sure about the Name and description yet) - Add pkg-message - pkg-plist fixes TODO: - Testing (poudriere)
Meanwhile 0.8.4 has been released. I have started to work on an updated patch, but don't hold your breath.
Created attachment 158872 [details] Update to 0.8.4
I committed my patch. Thanks for your help