Bug 197530 - [NEW PORT] net-im/corebird
Summary: [NEW PORT] net-im/corebird
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on: 197599
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-11 02:38 UTC by Carlos J Puga Medina
Modified: 2015-03-03 19:05 UTC (History)
4 users (show)

See Also:


Attachments
corebird.shar (7.23 KB, text/plain)
2015-02-11 02:38 UTC, Carlos J Puga Medina
no flags Details
11-i386-corebird-build.log (94.86 KB, text/x-log)
2015-02-11 02:46 UTC, Carlos J Puga Medina
no flags Details
autoreconf.diff (501 bytes, patch)
2015-02-11 02:48 UTC, Carlos J Puga Medina
no flags Details | Diff
corebird.shar (7.27 KB, text/plain)
2015-02-28 20:50 UTC, Carlos J Puga Medina
no flags Details
corebird.shar (7.38 KB, text/plain)
2015-02-28 23:05 UTC, Carlos J Puga Medina
no flags Details
New shar proposal with tijl@ fixes (7.73 KB, text/plain)
2015-03-01 13:55 UTC, Thierry Thomas
no flags Details
corebird.shar (7.79 KB, text/plain)
2015-03-01 17:26 UTC, Carlos J Puga Medina
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-02-11 02:38:40 UTC
Created attachment 152857 [details]
corebird.shar

Corebird is a native GTK3 Twitter client that provides vital features such as
Direct Messages (DMs), Tweet notifications.

WWW: http://corebird.baedert.org/
Comment 1 Carlos J Puga Medina 2015-02-11 02:46:09 UTC
Created attachment 152858 [details]
11-i386-corebird-build.log

% portlint -AC
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.

The following patch is necessary in order to build properly net-im/corebird port.

Index: Mk/Uses/autoreconf.mk
===================================================================
--- Mk/Uses/autoreconf.mk
+++ Mk/Uses/autoreconf.mk
@@ -80,6 +80,9 @@
        @test -e ${CONFIGURE_WRKSRC}/${f} || ${TOUCH} ${CONFIGURE_WRKSRC}/${f}
 .endfor
        @(cd ${CONFIGURE_WRKSRC} && ${LOCALBASE}/bin/autoreconf -f -i)
+.if defined(USE_GNOME) && (${USE_GNOME:Mintltool} || ${USE_GNOME:Mintlhack})
+       @(cd ${CONFIGURE_WRKSRC} && ${LOCALBASE}/bin/intltoolize -f -c)
 .endif
+.endif

 .endif
Comment 2 Carlos J Puga Medina 2015-02-11 02:48:47 UTC
Created attachment 152859 [details]
autoreconf.diff
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-11 06:25:29 UTC
The autoreconf.diff comes from

https://reviews.freebsd.org/D976
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-11 06:26:43 UTC
And from

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194393
Comment 5 Olivier Duchateau freebsd_committer freebsd_triage 2015-02-15 18:13:47 UTC
Add also thierry@, he's working on Corebird.
Comment 6 Carlos J Puga Medina 2015-02-15 18:42:41 UTC
Olivier,

Did you tested corebird port? Now corebird has video support enabled.
Comment 7 Olivier Duchateau freebsd_committer freebsd_triage 2015-02-15 19:27:59 UTC
(In reply to Carlos Jacobo Puga Medina from comment #6)

Carlos, no I didn't tested video support.
Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2015-02-15 21:40:13 UTC
Actually, I did not see this PR, and wrote another port for Corebird.
Carlos, are'nt you affected by 197599?

With my version, on 10.1-STABLE/amd64, I cannot get an ID: it segfaults in Oauth / librest.

See https://github.com/baedert/corebird/issues/310
Comment 9 Carlos J Puga Medina 2015-02-15 21:44:38 UTC
(In reply to Thierry Thomas from comment #8)

No, for me corebird works properly. No crashes at the moment. Please, use my shar file.
Comment 10 Thierry Thomas freebsd_committer freebsd_triage 2015-02-15 22:17:05 UTC
(In reply to Carlos Jacobo Puga Medina from comment #9)

Exactly the same error with your version:

Starting program: /usr/ports/net-im/corebird/work/baedert-corebird-3399924/src/corebird 
[New LWP 101721]
[New Thread 80b006400 (LWP 101721/corebird)]

** (corebird:49640): WARNING **: MainWindow.vala:382: Couldn't load window geometry for screen_name `screen_name'

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 80b006400 (LWP 101721/corebird)]
0x00000008040ae08f in g_string_append_uri_escaped () from /usr/local/lib/libglib-2.0.so.0

With the same backtrace:

(gdb) bt
#0  0x00000008040ae08f in g_string_append_uri_escaped () from /usr/local/lib/libglib-2.0.so.0
#1  0x000000080149d911 in sign_hmac (proxy=0x80d540af0, call=0x80d548c40, oauth_params=0x80d5fff00) at oauth-proxy-call.c:149
#2  0x000000080149d476 in _prepare (call=0x80d548c40, error=0x7fffffffce70) at oauth-proxy-call.c:292
#3  0x0000000801496ee7 in prepare_message (call=0x80d548c40, error_out=0x7fffffffcf70) at rest-proxy-call.c:830
#4  0x0000000801496bfc in rest_proxy_call_async (call=0x80d548c40, callback=0x801498610 <_rest_proxy_call_async_cb>, weak_object=0x0, 
    userdata=0x7fffffffcf60, error=0x7fffffffcf70) at rest-proxy-call.c:979
#5  0x000000080149857d in rest_proxy_call_run (call=0x80d548c40, loop_out=0x0, error_out=0x7fffffffd1a0) at rest-proxy-call.c:1418
#6  0x000000080149b709 in oauth_proxy_request_token (proxy=0x80d540af0, function=0x55115d "oauth/request_token", callback_uri=0x551171 "oob", 
    error=0x7fffffffd1a0) at oauth-proxy.c:423
#7  0x00000000004bcf6a in account_create_widget_open_pin_request_site (self=0x80d5b3270) at widgets/AccountCreateWidget.c:256
#8  0x00000000004bf9d5 in account_create_widget_request_pin_clicked_cb (self=0x80d5b3270) at widgets/AccountCreateWidget.c:396
#9  0x00000000004be02c in _account_create_widget_request_pin_clicked_cb_gtk_button_clicked (_sender=0x80d58a4f0, self=0x80d5b3270)
    at widgets/AccountCreateWidget.c:401
8<    8<    8<
Comment 11 Carlos J Puga Medina 2015-02-15 22:25:49 UTC
It seems that the problem affects only to amd64. I'll take a look.
Comment 12 Thierry Thomas freebsd_committer freebsd_triage 2015-02-24 21:18:55 UTC
I've just committed a fix for librest (rev. 379839), and now Corebird works fine!
Comment 13 Thierry Thomas freebsd_committer freebsd_triage 2015-02-24 22:24:11 UTC
PR ports/194393 is closed, but corebird fails with the hereunder error:

===>  Configuring for corebird-0.9
You should add the contents of '/usr/local/share/aclocal/intltool.m4' to 'aclocal.m4'.
cp: m4/intltool.m4: No such file or directory
intltoolize: cannot copy '/usr/local/share/aclocal/intltool.m4' to 'm4/intltool.m4'
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/corebird

Have you an updated patch for this issue?

Note: for my own test version, I have been lazy, and I just used

do-configure:
	(cd ${WRKSRC} && ./autogen.sh --prefix=${PREFIX})

It works, but this is not very smart...
Comment 14 Olivier Duchateau freebsd_committer freebsd_triage 2015-02-25 04:42:02 UTC
(In reply to Thierry Thomas from comment #13)

Your ports tree is up to date?
Before revision r379150 [1], I used patch from D976 [2] and compilation works fine.

[1] https://svnweb.freebsd.org/changeset/ports/379150
[2] https://reviews.freebsd.org/D976
Comment 15 Thierry Thomas freebsd_committer freebsd_triage 2015-02-25 09:19:39 UTC
(In reply to Olivier Duchateau from comment #14)

Yes, my ports tree is up-to-date, but I tried it only with the included  corebird.shar, and without the patch from D976.
Comment 16 Carlos J Puga Medina 2015-02-25 10:09:21 UTC
Also see the build log on 11-CURRENT/i386 after autoreconf.mk patch was applied.
Comment 17 Thierry Thomas freebsd_committer freebsd_triage 2015-02-28 13:25:02 UTC
Back to the pool.

Maybe it's only me, but I cannot build it, and do not want to block this PR.
Comment 18 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-28 13:47:33 UTC
Can someone provide a consolidated patch that I can test ? Thanks.
Comment 19 Carlos J Puga Medina 2015-02-28 18:20:20 UTC
I can reproduce Thierry's problem. So I can confirm that r379150 broke it.

https://svnweb.freebsd.org/ports?view=revision&revision=379150

Using the previous patch solves the problem:

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152859
Comment 20 Carlos J Puga Medina 2015-02-28 18:21:20 UTC
(In reply to Kurt Jaeger from comment #18)

Kurt, the shar file is OK.
Comment 21 Carlos J Puga Medina 2015-02-28 20:50:14 UTC
Created attachment 153628 [details]
corebird.shar

New shar file which fixes the configure error
Comment 22 Carlos J Puga Medina 2015-02-28 23:05:54 UTC
Created attachment 153630 [details]
corebird.shar

Fix installation corebird(1) manpage
Comment 23 Thierry Thomas freebsd_committer freebsd_triage 2015-03-01 13:55:56 UTC
Created attachment 153640 [details]
New shar proposal with tijl@ fixes

This new shar file fixes the configure target (obtained from tijl@).
Comment 24 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-01 14:51:29 UTC
testing@work
Comment 25 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-01 16:03:57 UTC
The port does not build in poudriere (tested with 10.1a, 9.3a, 8.4i).

See http://people.freebsd.org/~pi/logs/net-im*
Comment 26 Carlos J Puga Medina 2015-03-01 16:09:12 UTC
(In reply to Kurt Jaeger from comment #25)

Can you try using the previous shar file?

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153630

I think that corebird needs to use his internal libtool. We need to fix Uses/autoreconf.mk
Comment 27 Tijl Coosemans freebsd_committer freebsd_triage 2015-03-01 17:06:12 UTC
Try adding USES=libtool
Comment 28 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-01 17:20:42 UTC
Yes, with USES=libtool it builds on all my test poudriere jails.
Comment 29 Carlos J Puga Medina 2015-03-01 17:26:06 UTC
Created attachment 153645 [details]
corebird.shar

Added USES=libtool to corebird/Makefile
Comment 30 commit-hook freebsd_committer freebsd_triage 2015-03-03 19:00:57 UTC
A commit references this bug:

Author: pi
Date: Tue Mar  3 18:59:56 UTC 2015
New revision: 380390
URL: https://svnweb.freebsd.org/changeset/ports/380390

Log:
  New port: net-im/corebird

  Corebird is a native GTK3 Twitter client that provides features
  such as Direct Messages (DMs), Tweet notifications.

  WWW: http://corebird.baedert.org/

  PR:		197530
  Submitted by:	Carlos Jacobo Puga Medina <cpm@fbsd.es>
  Reviewed by:	tijl, olivierd, thierry

Changes:
  head/net-im/Makefile
  head/net-im/corebird/
  head/net-im/corebird/Makefile
  head/net-im/corebird/distinfo
  head/net-im/corebird/files/
  head/net-im/corebird/files/patch-Makefile.am
  head/net-im/corebird/files/patch-configure.ac
  head/net-im/corebird/files/patch-data__Makefile.am
  head/net-im/corebird/files/patch-data__symbolics__Makefile.am
  head/net-im/corebird/files/patch-src__widgets__MediaVideoWidget.vala
  head/net-im/corebird/pkg-descr
  head/net-im/corebird/pkg-plist
Comment 31 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-03 19:05:25 UTC
Committed, thanks to all!