Created attachment 152931 [details] www-MT.patch update 5.2.12
Created attachment 152932 [details] russian-MT.patch
Created attachment 153133 [details] www-MT.patch2 add russian distfile
Created attachment 153134 [details] russian-MT.patch2 del russian patchfiles
This still needs QA (e.g. poudriere logs)
The patch fails to build currently: http://pd.valinor.palantiri.org/data/84amd64-default/2015-03-14_09h34m23s/logs/errors/MT-5.2.12,1.log
he's asking for a new (tested) patch. Without it the PR will be closed.
(In reply to John Marino from comment #6) will certainly have problem in ports-Mgmt/poudriere Problem does not occur with real environment and the directory is deleted. I ports-Mgmt/poudriere doubt?
I am not sure it is a poudriere fake error. It seems that a dependency (mysql?) is bringing in /var/db/mysql and MT is deleting it. It might work if you just remove the %%MYSQL%%@dir /var/db/mysql line from pkg-plist. Find out if mysql is installing /var/db/mysql and if so, don't let MT delete it.
Created attachment 154987 [details] www-MT.patch3 Roger. :-)
Latest patch fails as well: http://pd.valinor.palantiri.org/data/84amd64-default/2015-03-30_12h09m53s/logs/errors/MT-5.2.12,1.log I really highly recommend you to build poudriere and test your patches there, you'd make our life much easier.
true, but that being said, this is tricky. When he had "@dir ...", it failed because directory was missing. When he deletes "@dir ...", it fails because the directory is orphaned. Something weird is going on here. Some other port seems to be interfering.
The fix might be to remove "/var/db/mysql" from stagedir in post-install target...
ugh, entire do-install target is masked with "@". That needs changing. I will test my theory and report back.
hmm, obviously we can't "mkdir /var/db/mysql/WEBLOG_DATABASEDIR" and then "rmdir /var/db/mysql" ....
i see something else I don't like: post-install echo messages instead of using pkg-message or pkg-message.in ... That's wrong in my opinion.
installation has been done with "${CP} -R" rather than ${COPYSHARE_ ... This port is not withstanding scrutiny, there are a lot of things it is doing that it should not be doing.
I think the main problem is that sometimes DB_DIR is in ${STAGEDIR} and sometimes it isn't. yuck.
I think this is a shortcoming in the ports framework. I'm not sure how to make this work, honestly. The framework is getting confused by overlapping /var/db/mysql values.
I'm starting to think this is a problem with mysql, not MT. I don't think the mysql ports are setting /var/db/mysql in pkg-plist.
by the way, the SUB_LIST stuff is completely broken. Nothing after ".include <bsd" is included.
Created attachment 154998 [details] marino's attempt takefu, Please review my attempt at this. There were numerous problems as I commented previously. Mostly this gets it to work as intended, but there is one major change you need to be aware of and approve. I removed the "MT.conf" file. It was getting added as part of a post-install message and I doubt it was even correct. After many attempts, I finally got pkg-messages correct and showing, but MT.conf got lost along the way. I only figured it out when I was testing apache option. Is this okay? was MT.conf actually doing anything before, especially considering it may not have been populated correctly? it's presence didn't match the instructions on pkg-message. robak -- I think we need to ignore the error seen in check-plist when mysql option is set. I think it's an issue with most mysql ports.
takefu: by the way, i've been assuming that the DB_DIR has to be at /var/db/mysql. If it could be something else, e.g. /var/db/mt/WEBLOG ... then we wouldn't have this check-plist failure. Can you comment if this DB_DIR is required to be what it is currently?
Created attachment 155050 [details] www-MT.patch4 Lots of fixes, thank you. I tried to fix OptionsNG.
can we do that as a separate PR? Or at least as a post-commit patch? I literally spent hours on this and I don't want to start over again. If the "marino's attempt" patch is okay with you, I propose to commit that, and then you can fix options with a clean patch.
(In reply to John Marino from comment #24) I made for OptionsNG from the patch I made.
robak, I don't have anytime time today. takefu basically took my patch and cleaned up the options. The /var/db/mysql... line is still going to fail (it's expected) If you want to run this "patch4" through poudriere and visually check it over, feel free to commit. Otherwise I will probably come back to it in a few days.
The 'www-MT.patch4' patch is still failing for me: http://pd.valinor.palantiri.org/data/latest-per-pkg/MT/5.2.12%2c1/84amd64-default.log
as expected, see comment 26 and entire backlog
takefu, you made several what we call "gratuitous" changes -- changes that don't affect functionality, but screw up diff checks. For example, line 1 \ line 2 changed to line 1\ line 2 First, there's no different functionally second, the first example is preferred. We want spaces before continuity lines, even if it means "-V" shows two spaces between items third, like I said, it's showing a diff which makes review more complex. Please be careful about this. I'm reverting some unnecessary changes to make my review easier. Also, there was a change where you made the "mkdir" of the DBDIR invisible. I had it visible for a reason, but fine, we make it invisible. However, then you should have added it to the previous @${MKDIR} instead of keeping it as second command.
A commit references this bug: Author: marino Date: Fri Apr 3 16:11:41 UTC 2015 New revision: 383142 URL: https://svnweb.freebsd.org/changeset/ports/383142 Log: www/MT,russian/MT: Upgrade version 5.2.11 => 5.2.12 The port needed an overhaul, there were many issues with it. After the initial fix, the maintainer also made it optionsNG compliant. Note that when the default MYSQL option is selected, it will fail check-plist as a result of the mysql ports not handling /var/db/mysql creation correctly. To fix the check, the mysql ports need fixing. PR: 197588 Submitted by: takefu (airport.fm) overhaul by: marino Changes: head/russian/MT/Makefile head/www/MT/Makefile head/www/MT/distinfo head/www/MT/files/MT.conf.in head/www/MT/files/pm.apache.in head/www/MT/files/pm.default.in head/www/MT/pkg-plist
I can honestly say that I hate this PR. Closing, it's done.