Bug 197601 - net/omnitty: Allow >32-character hostnames
Summary: net/omnitty: Allow >32-character hostnames
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-02-13 22:11 UTC by david
Modified: 2015-03-01 22:16 UTC (History)
1 user (show)

See Also:


Attachments
Patch to net/omnitty/files/patch-main.c (1.25 KB, patch)
2015-02-13 22:11 UTC, david
no flags Details | Diff
typescript, showing "svn diff" & successful build (6.04 KB, text/plain)
2015-02-16 03:30 UTC, david
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description david 2015-02-13 22:11:19 UTC
Created attachment 152947 [details]
Patch to net/omnitty/files/patch-main.c

net/omnitty has a hard-coded 32-byte buffer for entering a hostname "by hand".  (Entering linger hostnames by reading a file avoids this limitation.)

The attached patch relaxes that to 64 bytes -- I was too lazy to fix it by allocating the storage dynamically -- and makes it a #defined constant (so one doesn't need to look for all other occurrences of the numeric string in question to try to determine if they might also be involved).

We already have a patch for the file in question (main.c), so the attached patch patches the existing patchfile.

I've tested it in a stable/10, environment (both i386 & amd64) -- we have some 33-character hostnames at work.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-16 02:52:40 UTC
Thanks for your submission David,

Can you attach success build output using either:

- poudriere testport or poudriere bulk -t, OR
- make stage && make check-plist && make stage-qa && make package

Poudriere is prefferred.

I note this port also has no maintainer, please feel free to take maintainership by updating the patch changing MAINTAINER= as well.
Comment 2 david 2015-02-16 03:30:04 UTC
Created attachment 153024 [details]
typescript, showing "svn diff" & successful build

Raw script(1) output -- so it's full of ^Ms (among other impediments to legibility).
Comment 3 commit-hook freebsd_committer 2015-03-01 22:15:51 UTC
A commit references this bug:

Author: marino
Date: Sun Mar  1 22:15:22 UTC 2015
New revision: 380230
URL: https://svnweb.freebsd.org/changeset/ports/380230

Log:
  net/omnitty: Allow greater than 32-character hostnames

  PR:		197601
  Submitted by:	David (catwhisker.org)

Changes:
  head/net/omnitty/Makefile
  head/net/omnitty/files/patch-main.c
Comment 4 John Marino freebsd_committer 2015-03-01 22:16:19 UTC
Thanks!