The diff viewer built into Bugzilla shows a bit of left-over junk, when you attach a diff generated by Subversion, which also changes properties. For example, take a look at this diff view: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152952&action=diff Each of the files has this part at the end, generated by Subversion: Property changes on: games/cube/files/patch-entities.cpp ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property It looks like Bugzilla picks up the + signs at the start of the line, and thinks that is part of the diff?
The problem seems to be within p5-PatchReader, which is used to extract the information from a diff. It is unable to deal with SVN diffs properly at the moment. We will look into this.
Created attachment 153180 [details] p5-PatchReader Update The following patch should fix the problem. I could not notice any side effects on other patches, so I assume the patch to work correctly for most (if not all) patches.
Toni: can you review the patch and tell me, if it is okay to commit it?
Looks good.
A commit references this bug: Author: mva Date: Sat Feb 21 09:33:11 UTC 2015 New revision: 379493 URL: https://svnweb.freebsd.org/changeset/ports/379493 Log: - Ignore SVN property changes in PatchReader::Raw. They were mistaken for line changes of the original patch. - This fixes Bugzilla's patch viewer not to show SVN property changes as line additions or removals of a file. PR: 197607 Reported by: dim@ Approved by: toni.viemero@iki.fi (maintainer) Changes: head/devel/p5-PatchReader/Makefile head/devel/p5-PatchReader/files/patch-lib__PatchReader__Raw.pm
The PatchReader module has been updated and the property changes should not be shown anymore.