Bug 197610 - net/enet: unbreak on DragonFly
Summary: net/enet: unbreak on DragonFly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-14 05:03 UTC by Jan Beich
Modified: 2015-02-14 10:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nemysis)


Attachments
files/patch-unix.c (1.20 KB, patch)
2015-02-14 05:03 UTC, Jan Beich
koobs: maintainer-approval? (nemysis)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2015-02-14 05:03:55 UTC
Created attachment 152956 [details]
files/patch-unix.c

DragonFly's libc has $FreeBSD$ in some places, so gethostby*_r() return result in one of the args. libenet breakage can be worked around either with USES=alias or fixed in the few places the function is used.

http://bxr.su/DragonFly/lib/libc/net/gethostnamadr.c#486
vs.
http://bxr.su/NetBSD/lib/libc/net/gethnamaddr.c#520

$ make
...
checking for gethostbyaddr_r... yes
checking for gethostbyname_r... yes
...
unix.c: In function 'enet_address_set_host':
unix.c:110:5: warning: passing argument 5 of 'gethostbyname_r' from incompatible pointer type [enabled by default]
In file included from unix.c:13:0:
/usr/include/netdb.h:244:6: note: expected 'struct hostent **' but argument is of type 'int *'
unix.c:110:5: error: too few arguments to function 'gethostbyname_r'
In file included from unix.c:13:0:
/usr/include/netdb.h:244:6: note: declared here
unix.c: In function 'enet_address_get_host':
unix.c:168:64: warning: passing argument 7 of 'gethostbyaddr_r' from incompatible pointer type [enabled by default]
In file included from unix.c:13:0:
/usr/include/netdb.h:242:6: note: expected 'struct hostent **' but argument is of type 'int *'
unix.c:168:64: error: too few arguments to function 'gethostbyaddr_r'
In file included from unix.c:13:0:
/usr/include/netdb.h:242:6: note: declared here
*** Error code 1
Comment 1 Bugzilla Automation freebsd_committer 2015-02-14 05:03:55 UTC
Auto-assigned to maintainer nemysis@FreeBSD.org
Comment 2 commit-hook freebsd_committer 2015-02-14 10:48:35 UTC
A commit references this bug:

Author: nemysis
Date: Sat Feb 14 10:48:25 UTC 2015
New revision: 378956
URL: https://svnweb.freebsd.org/changeset/ports/378956

Log:
  - Add patch, fix build on DragonFly [1]
    https://github.com/lsalzman/enet/issues/42

  PR:		197610
  Submitted by:	jbeich [1]

Changes:
  head/net/enet/files/
  head/net/enet/files/patch-unix.c