Bug 197671 - www/webkit-gtk3: Broken on gcc5 and pushes clang-only cxx-flags
Summary: www/webkit-gtk3: Broken on gcc5 and pushes clang-only cxx-flags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome mailing list
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-02-15 00:01 UTC by John Marino
Modified: 2015-03-11 18:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
patch to allow building port on gcc-5 (515 bytes, patch)
2015-02-15 00:01 UTC, John Marino
no flags Details | Diff
resubmitted -- files patch was missing due to not being added in svn (1.70 KB, patch)
2015-02-15 00:04 UTC, John Marino
koobs: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2015-02-15 00:01:17 UTC
Created attachment 152991 [details]
patch to allow building port on gcc-5

There are two problems with building webkit on gcc-5.

1) The configure check is brain-dead, it can't figure out 5 > 4.x

2) -Wno-c++11-extensions is a clang-only flag that gcc-5 will not accept.

The attached patch adds a patch to configure that fixes the configure check.  It also groups -Wno-c++11-extensions with another clang-only flag.

This fixes the build with gcc5 and probably gcc4.9 as well (but I'm not sure when the flag started getting rejected)

At least 75 ports depends on webkit-gtk3, directly or indirectly.
Comment 1 Bugzilla Automation freebsd_committer 2015-02-15 00:01:17 UTC
Auto-assigned to maintainer gnome@FreeBSD.org
Comment 2 John Marino freebsd_committer 2015-02-15 00:04:11 UTC
Created attachment 152992 [details]
resubmitted -- files patch was missing due to not being added in svn
Comment 3 commit-hook freebsd_committer 2015-03-11 18:28:06 UTC
A commit references this bug:

Author: marino
Date: Wed Mar 11 18:27:19 UTC 2015
New revision: 381025
URL: https://svnweb.freebsd.org/changeset/ports/381025

Log:
  www/webkit-gtk(2,3): Fix build on gcc5 and isolate clang-only flag

  PR:		197669
  PR:		197671
  Submitted by:	marino
  Approved by:	maintainer timeout

Changes:
  head/www/webkit-gtk2/Makefile
  head/www/webkit-gtk2/files/patch-configure
  head/www/webkit-gtk3/Makefile
  head/www/webkit-gtk3/files/patch-configure