Bug 197703 - security/ipsec-tools: build fails on 8.4-RELEASE
Summary: security/ipsec-tools: build fails on 8.4-RELEASE
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: VANHULLEBUS Yvan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-16 11:28 UTC by Victor Sudakov
Modified: 2015-12-18 08:58 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (vanhu)

Attachments
Poudriere failed build log (7.89 KB, text/plain)
2015-02-16 11:28 UTC, Victor Sudakov 		no flags Details
patch to remove erroneous patch (853 bytes, patch)
2015-03-15 20:22 UTC, geoffroy desvernay 		no flags Details | Diff
successfull build log after patch (69.09 KB, text/plain)
2015-03-15 20:22 UTC, geoffroy desvernay 		no flags Details
patch to unbreak ipsec-tools build on FreeBSD 8 (4.95 KB, patch)
2015-05-29 05:38 UTC, Don Lewis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2015-02-16 11:28:31 UTC 
Created attachment 153034 [details]
Poudriere failed build log

security/ipsec-tools does not build on 8.4-RELEASE-p23 ("Patch patch-src-racoon-isakmp_cfg.c failed to apply cleanly").

I am attaching the poudriere log.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-16 11:28:31 UTC 
Auto-assigned to maintainer vanhu@FreeBSD.org
Comment 2 VANHULLEBUS Yvan freebsd_committer freebsd_triage 2015-02-19 13:44:32 UTC 
Work done by patch-src-racoon-isakmp_cfg.c is (should be ?) already done by existing patch8-utmp.diff.

Having a quick look at both patches, patch-src-racoon-isakmp_cfg.c tries to disable what has already been correctly patched by patch8-utmp.diff (well, at least, it used to work for a while, but I don't have an older enough install to test).

Can a ports commiter just remove patch-src-racoon-isakmp_cfg.c ?
It should fix the situation on all versions.
Comment 3 geoffroy desvernay 2015-03-15 20:22:12 UTC 
Created attachment 154403 [details]
patch to remove erroneous patch

build with poudriere
Comment 4 geoffroy desvernay 2015-03-15 20:22:56 UTC 
Created attachment 154404 [details]
successfull build log after patch
Comment 5 Don Lewis freebsd_committer freebsd_triage 2015-05-29 05:30:13 UTC 
(In reply to VANHULLEBUS Yvan from comment #2)

patch-src-racoon-isakmp_cfg.c is needed for FreeBSD 9 and newer that uses the utmpx API.

patch8-utmp.diff is for the older utmp API.
Comment 6 Don Lewis freebsd_committer freebsd_triage 2015-05-29 05:38:11 UTC 
Created attachment 157241 [details]
patch to unbreak ipsec-tools build on FreeBSD 8

This patch merges patch-src-racoon-isakmp_cfg.c and patch8-utmp.diff using the appropriate #if magic to use the proper utmp vs. utmpx API on FreeBSD 8 vs. FreeBSD 9 and newer.  EXTRA_PATCHES has been removed from the Makefile because it is no longer necessary.

Builds on FreeBSD 8.4-RELEASE, 9.3-RELEASE, and 10.1-RELEASE, both amd64 and i386.  Unfortunately I do not have a test environment for runtime testing.
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2015-12-18 08:58:07 UTC 
FreeBSD 8 is no longer supported.