Bug 197750 - archivers/unzip: INSTALL_AS_INFOUNZIP confuses users and breaks dependent ports
Summary: archivers/unzip: INSTALL_AS_INFOUNZIP confuses users and breaks dependent ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-16 22:54 UTC by Dmitry Marakasov
Modified: 2015-02-21 08:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
Patch (1.82 KB, patch)
2015-02-16 22:54 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2015-02-16 22:54:19 UTC
Created attachment 153092 [details]
Patch

I've been investigating openjdk7 build failure for some user, and discovered that he had INSTALL_AS_INFOUNZIP in his make.conf. Obviously, it made unzip port not install bin/unzip binary, which broke dependent ports that need unzip.

Now I wonder, what is the purpose of that knob? I see no reason for optional installation of infounzip binary, so it may be installed unconditionally as a link to unzip (or vice versa). If the point is in optional installation of unzip binary, it requires cooperation from ports framework, namely Uses/zip.mk or bsd.commands.mk, which should tweak unzip dependency.

The way INSTALL_AS_INFOUNZIP is implemented now is broken and if there's no real reason behind it, I propose to remove it. Patch attached.
Comment 1 Bugzilla Automation freebsd_committer 2015-02-16 22:54:19 UTC
Auto-assigned to maintainer ehaupt@FreeBSD.org
Comment 2 Emanuel Haupt freebsd_committer 2015-02-21 08:47:38 UTC
I fully agree with your reasoning. I've removed the option based on your patch. Thanks!
Comment 3 commit-hook freebsd_committer 2015-02-21 08:47:44 UTC
A commit references this bug:

Author: ehaupt
Date: Sat Feb 21 08:46:48 UTC 2015
New revision: 379492
URL: https://svnweb.freebsd.org/changeset/ports/379492

Log:
  Remove the historic option INSTALL_AS_INFOUNZIP which would install the unzip
  binary as info-unzip instead of unzip. Setting this options breaks ports such as
  java/openjdk7. This could be fixed but the submitter an I don't see a good
  reason why to keep this option.

  PR:		197750
  Submitted by:	amdmi3

Changes:
  head/archivers/unzip/Makefile