Created attachment 153226 [details] Proposed patch (since 379431 revision) Patch to update deskutils/treesheets port from 0.0.20141225 to v0.0.20150117 version. Look following link for changes: https://github.com/aardappel/treesheets/compare/6ff99fb...0191b1f The current method of building software just works. But there is some claims from ports r379431, which unrelated to the actual practice (i.e. the possibility to do the same with different methods), in my opinion. Therefore, I created manual Makefile also. It not so generic as previous method (from maintenance point of view), but it also just works. - Add manual Makefile to build application
Created attachment 153227 [details] The poudriere testport log (FreeBSD 10 amd64)
Created attachment 153256 [details] Proposed patch (since 379431 revision) Looks like, I understood the ports r379431 claims wrong. Basically, it meant to simplify the building, without the need to change the build.sh file. The changed patch attached.
Created attachment 153257 [details] The poudriere testport log (FreeBSD 10 amd64)
Created attachment 153259 [details] Proposed patch (since 379431 revision) Return "${SETENV} ${MAKE_ENV}" for port's Makefile.
Created attachment 153260 [details] The poudriere testport log (FreeBSD 10 amd64)
(In reply to comment #4) > Return "${SETENV} ${MAKE_ENV}" for port's Makefile. But I think, that it is not needed, in case of direct build method. In previous method, the WX_CONFIG variable might be missing, which caused build failure on DragonFly BSD. I renew the attachments.
Comment on attachment 153259 [details] Proposed patch (since 379431 revision) This is the attachment you want. Failure to set environment is an error, full stop. Whether or not the port builds on a particular environment without it is irrelevant. It is the same principle of porters handbook 12.9 (not overriding flags). You can't "override" or prevent the alteration of the environment either.
The attached patch looks good to me and is an improvement over the current build target. I'm moving this PR to patch-ready status.
(In reply to comment #8) Ok, thanks.
A commit references this bug: Author: robak Date: Sun Mar 1 17:07:39 UTC 2015 New revision: 380213 URL: https://svnweb.freebsd.org/changeset/ports/380213 Log: deskutils/treesheets: update 0.0.20141225 -> 0.0.20150117 PR: 197856 Submitted by: lightside@gmx.com Changes: head/deskutils/treesheets/Makefile head/deskutils/treesheets/distinfo
Committed, thanks for your work!