Bug 197880 - [patch] update devel/p5-Module-Build to 0.4211
Summary: [patch] update devel/p5-Module-Build to 0.4211
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-perl (Nobody)
Depends on:
Reported: 2015-02-21 16:49 UTC by Adam Weinberger
Modified: 2015-02-25 19:40 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (perl)
adamw: exp-run?

0.4211 (2.97 KB, patch)
2015-02-21 16:49 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2015-02-21 16:49:40 UTC
Created attachment 153279 [details]

The attached patch updates Module::Build to 0.4211.

Changes: https://metacpan.org/changes/distribution/Module-Build

Because it's used by so many ports it's probably worth considering an exp-run for it.

It gives an error about wanting a newer version of inc::latest for the optional "Bundle Module::Build in inc/" feature but I think it's safe to ignore that?
Comment 1 Bugzilla Automation freebsd_committer 2015-02-21 16:49:40 UTC
Auto-assigned to maintainer perl@FreeBSD.org
Comment 2 Adam Weinberger freebsd_committer 2015-02-21 16:50:07 UTC
Assigning to portmgr for consideration for exp-run.
Comment 3 Andrej Zverev freebsd_committer 2015-02-22 21:16:03 UTC
IMHO, I don't think you need to run exp-run, you can look history and only few time people did such thing for this module.

As test just take random 10 ports which are consumers of Module::Build and try to build them with a new version.

Also don't forget what you need to modify Mk/Uses/perl5.mk to use latest version of Module::Build.
Comment 4 Mathieu Arnold freebsd_committer 2015-02-22 21:20:32 UTC
No, you *do not* *need* to touch Mk/Uses/perl5.mk to use the latest version.

You *only* do that if you have *compelling* evidence that ports need to have the latest version right now.

99.9% of the time, you do *not* touch Mk/Uses/perl5.mk because no ports *needs* the latest version.
Comment 5 Andrej Zverev freebsd_committer 2015-02-23 10:40:01 UTC
(In reply to Mathieu Arnold from comment #4)
Yes, Makefile contain comment about this, but as i'm already mentioned Perl toolchain must be always latest versions. I'm talking about Module::Build and ExtUtils::MakeMaker. For example nobody cares why we are using M::B from ports while it also in core and mixing usage of EU::MM instead of always use latest form ports. 

Don't get me wrong, but it's hard to use your rule of compelling evidence here. If we building Foo-Y with toolchain version X we must be sure what user using same toolchain version X to build Foo-Y. For me this sound reasonable :-)
Comment 6 Adam Weinberger freebsd_committer 2015-02-24 18:24:49 UTC
That was the main reason that I thought I'd ask about an exp-run, to be positive that the minimum required version in Uses/perl5.mk didn't need to be bumped.

I haven't found any problems using the new version so far. If portmgr and the rest of perl@ are comfortable with it I'm happy to commit it, but as this is new territory for me I figured I'd ask the people who've dealt with it before.
Comment 7 Antoine Brodin freebsd_committer 2015-02-25 18:28:01 UTC
(In reply to Adam Weinberger from comment #6)

An exp-run won't catch if the minimum required version in Uses/perl5.mk need to be bumped or not.

From an exp-run point of view, it's ok.

I let perl@ folks decide about version bumps in perl5.mk and the error about newer version of inc::latest since I have no clue about this.
Comment 8 commit-hook freebsd_committer 2015-02-25 19:40:06 UTC
A commit references this bug:

Author: adamw
Date: Wed Feb 25 19:39:47 UTC 2015
New revision: 379959
URL: https://svnweb.freebsd.org/changeset/ports/379959

  Update to 0.4211.

  Changes: https://metacpan.org/changes/distribution/Module-Build

  This update brings in a dependency on p5-CPAN-Meta, which itself has
  a number of dependencies.

  PR:		197880

Comment 9 Adam Weinberger freebsd_committer 2015-02-25 19:40:37 UTC
Okay. I'm committing this. I've been building everything with it for a couple days now and nothing's caught fire.