Bug 197984 - [maintainer update] net-mgmt/seafile-gui: update to version 4.1.0
Summary: [maintainer update] net-mgmt/seafile-gui: update to version 4.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-24 06:28 UTC by Jingfeng Yan
Modified: 2015-03-01 19:01 UTC (History)
2 users (show)

See Also:


Attachments
svn diff (3.05 KB, patch)
2015-02-24 06:28 UTC, Jingfeng Yan
no flags Details | Diff
svn diff (3.10 KB, patch)
2015-02-24 16:56 UTC, Jingfeng Yan
no flags Details | Diff
testport result (346.91 KB, text/plain)
2015-02-24 16:57 UTC, Jingfeng Yan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jingfeng Yan 2015-02-24 06:28:02 UTC
Created attachment 153430 [details]
svn diff

update version.
Comment 1 Jingfeng Yan 2015-02-24 06:36:15 UTC
test result is on the way to post.
Comment 2 Jingfeng Yan 2015-02-24 16:52:16 UTC
I encountered two issues, need some feedbacks:

(1) fetch http://codeload.github.com/haiwen/seafile-client/legacy.tar.gz/v4.1.0?dummy=/seafile-gui-4.1.0.tar.gz failed.  When I worked on 3.x version, the fetch does not bring me any problem.  What I found is (I have not digged deeply).  
- the portsnap is one-day old. (2015/02/23)
- When I change the PORTNAME= seafile-client (originally it is seafile-gui), it is fine to pull the dist.  I don't really like seafile-client naming in the Github because it is very confusing.  Haiwen/Seafile carries seafile client and server.  "What is another client", it is GUI or desktop version (even not mobile version).  

!! This brings me AN IMPORTANT PROBLEM !!  Shall I have to rename the directory name (net-mgmt/seafile-gui).  How I can do it?  Thanks.

(2) net-mgmt/seafile-gui needs 118 ports to build, graphics/cairo and gtk-update-icon-cache-2.24.25 need to be built.  In order to built gtk-update-icon-cache-2.24.25, I have to set option for graphics/cairo to disable XCB (unchecked the option having XCB).  Otherwise, gtk-update-icon-cache-2.24.25 configuration will fail because

cairo need x11 enabled 

This is somehow misleading too.  X11 has been enabled, but XCB has to be disabled.  I don't hit this problem before. 

Overall, the building and running 4.10 for the GUI have no problem.
Comment 3 Jingfeng Yan 2015-02-24 16:56:53 UTC
Created attachment 153449 [details]
svn diff
Comment 4 Jingfeng Yan 2015-02-24 16:57:51 UTC
Created attachment 153450 [details]
testport result
Comment 5 Jingfeng Yan 2015-02-24 17:13:23 UTC
(In reply to Jingfeng Yan from comment #2)

P.S>
MOVING the directory name for this port will not affect the others.  No other ports depends on it.  But net-mgmt level Makefile should be changed.  I don't know I should provide which level diff for this case.  Or current diff is fine, and someone like you will take care of the rest.
Comment 6 John Marino freebsd_committer 2015-03-01 18:18:03 UTC
We should not have to rename the port in order to make GH pulls happy.  I'm not going to do that, I'll try to figure out the problem.

on the cairo thing, both are on by default:
  X11=on: X11 (graphics) support
  XCB=on: Enable XCB (X C-language Binding) Support

So we are okay in the default case.  Maybe I'll added a message at the end of the configure target to give a hint in case it fails there.
Comment 7 commit-hook freebsd_committer 2015-03-01 18:57:32 UTC
A commit references this bug:

Author: marino
Date: Sun Mar  1 18:56:57 UTC 2015
New revision: 380223
URL: https://svnweb.freebsd.org/changeset/ports/380223

Log:
  net-mgmt/seafile-gui: Upgrade version 3.1.5 => 4.1.0

  PR:		197984
  Submitted by:	maintainer (Jingfeng Yan)

Changes:
  head/net-mgmt/seafile-gui/Makefile
  head/net-mgmt/seafile-gui/distinfo
  head/net-mgmt/seafile-gui/files/patch-CMakeLists.txt
Comment 8 John Marino freebsd_committer 2015-03-01 19:01:06 UTC
The fix for GH pull was simple, all you needed to do was define DISTNAME.  There was no relocation of the port.

I added a comment about cairo build requirements and misleading configure error in the Makefile as well.

I think all of the new versions are in ports now.