Bug 198044 - mail/squirrelmail: leftover config.php file
Summary: mail/squirrelmail: leftover config.php file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 20:28 UTC by Dmitry Marakasov
Modified: 2015-03-24 19:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2015-02-25 20:28:27 UTC
squirrelmail plugins builds report %%SQUIRRELDIR%%/config/config.php leftover:

---
====>> Checking for extra files and directories
====>> Error: Files or directories left over:
%%SQUIRRELDIR%%/config/%%SQUIRREL_PLUGIN_CONFIG%%
---

full log: http://poudriere.amdmi3.ru/data/10-amd64-default/2015-02-16_20h36m16s/logs/errors/squirrelmail-calendar_file_backend-plugin-1.0_3.log
Comment 1 Bugzilla Automation freebsd_committer 2015-02-25 20:28:27 UTC
Auto-assigned to maintainer adamw@FreeBSD.org
Comment 2 Adam Weinberger freebsd_committer 2015-03-18 04:25:49 UTC
I'm not entirely sure on the best way to resolve this. Maybe disabling activation if PACKAGE_BUILDING is defined?
Comment 3 commit-hook freebsd_committer 2015-03-24 19:17:25 UTC
A commit references this bug:

Author: adamw
Date: Tue Mar 24 19:16:39 UTC 2015
New revision: 382161
URL: https://svnweb.freebsd.org/changeset/ports/382161

Log:
  Update squirrelmail* to 20150324, and clean up permission/owner handling in
  the plists.

  Also, avoid registering plugins during package build. It only makes sense to
  run the registration on end-user machines, and running it during package building
  leads to a stagedir violation, as noted in [1].

  PR:		198044 [1]
  Submitted by:	amdmi3

Changes:
  head/mail/squirrelmail/Makefile
  head/mail/squirrelmail/bsd.squirrelmail.mk
  head/mail/squirrelmail/distinfo
  head/mail/squirrelmail/pkg-plist
  head/mail/squirrelmail-decode/pkg-plist
  head/mail/squirrelmail-translations/Makefile
  head/mail/squirrelmail-translations/distinfo
  head/mail/squirrelmail-translations/pkg-plist
Comment 4 Adam Weinberger freebsd_committer 2015-03-24 19:17:37 UTC
Testing for [ -z $PACKAGE_BUILDING ] should DTRT here. Thanks for this PR, Dmitry!