Bug 198224 - mail/qpopper: get rid of gcc dependency
Summary: mail/qpopper: get rid of gcc dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 13:38 UTC by Dmitry Marakasov
Modified: 2015-03-04 16:34 UTC (History)
2 users (show)

See Also:
bc979: maintainer-feedback+


Attachments
Patch (1.24 KB, patch)
2015-03-03 13:38 UTC, Dmitry Marakasov
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2015-03-03 13:38:19 UTC
Created attachment 153710 [details]
Patch

qpopper requires gcc for a single performance-related compiler flag which clang doesn't know. This is needless, remove the flag if clang is used and drop GCC dependency.
Comment 1 John Marino freebsd_committer 2015-03-04 16:30:47 UTC
if the flag is not needed, why not just remove it unconditionally and don't even bother with USES=compiler:features ?
Comment 2 commit-hook freebsd_committer 2015-03-04 16:32:02 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Mar  4 16:31:55 UTC 2015
New revision: 380446
URL: https://svnweb.freebsd.org/changeset/ports/380446

Log:
  - Don't needlessly require gcc

  PR:		198224
  Submitted by:	amdmi3
  Approved by:	bc979@lafn.org (maintainer)

Changes:
  head/mail/qpopper/Makefile
Comment 3 Dmitry Marakasov freebsd_committer 2015-03-04 16:34:21 UTC
(In reply to John Marino from comment #1)
Because it may improve performance on gcc and because it's better to not change upstream code unless it's really needed.