Bug 198324 - Mk/bsd.port.mk: speed up "make clean"
Summary: Mk/bsd.port.mk: speed up "make clean"
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-05 19:33 UTC by Mikhail Teterin
Modified: 2016-04-13 14:52 UTC (History)
1 user (show)

See Also:

Attachments
Speed up "make clean" (1.04 KB, patch)
2015-03-05 19:33 UTC, Mikhail Teterin 		mi: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2015-03-05 19:33:24 UTC 
Created attachment 153853 [details]
Speed up "make clean"

Currently "make clean" first visits each of the port's dependencies twice -- first to build their list of dependencies and then to perform the actual removal of WRKDIR of each one.

The proposed change will remove the second visit -- passing the list of collected WRKDIRs directly to rm(1) (by way of xargs, just in case the list might become too long some day).
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2016-04-13 12:17:45 UTC 
> Feedback Timeout

This resolution is only applicable, when the SUBMITTER fails to respond in time?

If portmgr is still too busy, this can keep on waiting...
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2016-04-13 14:16:20 UTC 
This is an infrastructure PR, with a patch.
Said patch does not apply, but it's beyond the point.

It needs to be tested, with an exp-run, which is something that the submitter has to ask for.  If you still want this, update the patch so it can be tested, and ask for an exp-run.