Created attachment 153901 [details] diff Update databases/riak: update to 2.0.5
Created attachment 153902 [details] update patch USE_GCC=yes and removed post-install
Created attachment 153907 [details] using %%ETCDIR%% Update patch to use %%ETCDIR%%
Created attachment 153931 [details] diff -ruN riak.orig riak (fixed previous patch) Patch created using: diff -ruN riak.orig riak To use it: cd /usr/ports/databases/riak patch -E -p1 < /path/to/riak.diff find . -name "*.orig" -exec rm -f {} \; One patched it should compile and install: make install clean
A commit references this bug: Author: robak Date: Sat Mar 7 10:52:49 UTC 2015 New revision: 380681 URL: https://svnweb.freebsd.org/changeset/ports/380681 Log: graphics/converseen: update 0.9.0 -> 0.9.1 PR: 198355 Submitted by: Nicolas de Bari Embriz <nbari@dalmp.com> Changes: head/graphics/converseen/Makefile head/graphics/converseen/distinfo
(In reply to commit-hook from comment #4) This ended up in this PR by mistake - the above message is for PR 198319.
Hi, The patch you've sent is failing to build: http://pd.valinor.palantiri.org/data/101amd64-default/2015-03-07_17h58m01s/logs/errors/riak-2.0.5.log You might want to look at the current port, what it was doing to get rid of things like 'bash' dependency. Kind regards, Bartek Rutkowski
What about using: BUILD_DEPENDS= bash:${PORTSDIR}/shells/bash ?
Created attachment 153981 [details] fixed BASH dependency Fixed BASH dependecy
Adding bash as a port dependency, while would make that particular disappear, is wrong solution, because the port doesnt realy rely on the bash and bash its too big otherwise to force users to have it, just because it 'fixes' that error. The proper solution is to follow the original riak port (again, study it please, it does the thing it does for valid reasons) and read the Porters Handbook on how to handle such problems. Also, what's the reason for using GCC?
Your latest patch fails to build: http://pd.valinor.palantiri.org/data/101amd64-default/2015-03-08_00h43m54s/logs/errors/riak-2.0.5.log Could you please test the patch with Poudriere and Portlint and submit it when all reported errors are gone?
I am using GCC since port needs gmake otherwise won't compile, any other idea how how to test the port before setting up Poudriere?
Created attachment 154128 [details] poudriere pass Ugly patch to make the port work. pending stuff is how to remove the solr dependency please check and give me more advices of how to improve it. regards.
At first glance (portlint and poudriere build tests): * MASTER_SITES entries are underintented * DISTFILES are overindented * Line 25 has spaces instead of tabs * Why are you forcing the usage of GCC? * The port should not use Solr downloaded from the internet - there is Solr in ports (if it needs it in first place - it might be possible that Riak Search should be a separate port) * The port doesnt handle sample files properly * The port do-install and post-install phases are redundant * The port fails to build: http://pd.valinor.palantiri.org/data/84amd64-default/2015-03-10_12h54m50s/logs/errors/riak-2.0.5.log Given this is a rather large update, have you actually tried out the port? Does it work, does it start the Riak database, and if it does, does that database works (as in, you can connect to it, write data and so on), does it stop cleanly?
This is the steps I follow in order to make poudriere compile the port: 1. download the patch from: https://bz-attachments.freebsd.org/attachment.cgi?id=154128 2. patch -E -p1 < /tmp/patch 3. find . -iname "*.orig" -exec rm -f {} \; 4. poudriere testport -j 10amd64 -p development -o databases/riak I am using gcc because of this: https://github.com/basho/riak/issues/496 meanwhile I will test riak, so far starts,restarts,stops as expected.
Please, address all the point mentioned in my comment, before sending a new patch for testing.
Created attachment 154161 [details] removed yokozuna removed yokozuna dependency Cleaned port to use only do-install port passed poudriere testport -j 10amd64 -p development -o databases/riak please check it and let me know what else to improve. maybe later we could have a <category>/yokozuna port
(In reply to nbari from comment #16) Still the @sample got lost in translation.
Hi, I fixed the @sample here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198517 because of the dependencies and since bashio is maintaining both riak 1.4.x and riak 2.0.x maybe is good to have both ports riak1 and riak2 respectively Also some security features not working on version 2 of the riak2 port I submitted since I am not using bashio-erlang. What could be the best way of create the port ?
I am rejecting this PR because it shouldnt be an update to existing Riak 1.4.x port, but rather a separate port PR, and it turns out one has already been submitted in PR 198517.