Bug 198397 - [PATCH] ftp/curl: GSSAPI_BASE and LibreSSL include overlap
Summary: [PATCH] ftp/curl: GSSAPI_BASE and LibreSSL include overlap
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-07 20:42 UTC by Bernard Spil
Modified: 2015-03-28 11:38 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
svn diff for ftp/curl (982 bytes, patch)
2015-03-07 20:42 UTC, Bernard Spil
no flags Details | Diff
Poudriere testport for ftp/curl (346.76 KB, text/plain)
2015-03-07 20:42 UTC, Bernard Spil
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2015-03-07 20:42:15 UTC
Created attachment 153968 [details]
svn diff for ftp/curl

During a build of all ports with LibreSSL some issues with the ftp/curl port were detected
1. When GSSAPI_BASE is enabled, LibreSSL is not detected due to the overlap in /usr/include/openssl and /usr/local/include/openssl headers
2. LibreSSL does not support SRP (SSL_NO_SRP)

The patch addresses both issues by adding to IGNORE tests. Just tested the port with GSSAPI_KRB5 + LibreSSL and that was OK. This may make the build fail for users and should get an UPDATING entry?

20150307:
  AFFECTS: users of ftp/curl and port's OpenSSL/LibreSSL
  AUTHOR: bernard.spil@gmail.com

  - When GSSAPI_BASE is selected, configure failed to detect OpenSSL/
    LibreSSL from ports and link against base OpenSSL instead
  - LibreSSL does not support SRP yet the port allowed SRP to be enabled
    when security/libressl was used

  Users of LibreSSL:
  configure the ftp/curl port and disable SRP

  Users of port's OpenSSL/LibreSSL:
  configure the ftp/curl port to use no GSS-API or krb5/heimdal option
Comment 1 Bernard Spil freebsd_committer 2015-03-07 20:42:39 UTC
Created attachment 153969 [details]
Poudriere testport for ftp/curl
Comment 2 commit-hook freebsd_committer 2015-03-28 11:37:59 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Mar 28 11:37:42 UTC 2015
New revision: 382461
URL: https://svnweb.freebsd.org/changeset/ports/382461

Log:
  - Add IGNORE for LibreSSL

  PR:		198397 (based on)
  Submitted by:	Bernard Spil <spil.oss@gmail.com>

Changes:
  head/ftp/curl/Makefile
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2015-03-28 11:38:32 UTC
Committed. Thanks!