Bug 198405 - [PATCH] gnop: Count all BIO types
Summary: [PATCH] gnop: Count all BIO types
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Edward Tomasz Napierala
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-07 23:33 UTC by fullermd
Modified: 2016-01-12 09:27 UTC (History)
1 user (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2015-03-07 23:33 UTC, fullermd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fullermd 2015-03-07 23:33:16 UTC
Created attachment 153982 [details]
Patch

gnop(8) already stores up and shows stats for the number of BIO_READ and BIO_WRITE calls that pass through it.  Counting the other types as well makes it more useful for testing other stuff.
Comment 1 Edward Tomasz Napierala freebsd_committer 2015-09-16 00:11:44 UTC
https://reviews.freebsd.org/D3679
Comment 2 commit-hook freebsd_committer 2015-10-10 09:03:59 UTC
A commit references this bug:

Author: trasz
Date: Sat Oct 10 09:03:32 UTC 2015
New revision: 289110
URL: https://svnweb.freebsd.org/changeset/base/289110

Log:
  Make geom_nop(4) collect statistics on all types of BIOs, not just
  reads and writes.

  PR:		kern/198405
  Submitted by:	Matthew D. Fuller <fullermd at over-yonder dot net>
  MFC after:	1 month
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D3679

Changes:
  head/sbin/geom/class/nop/gnop.8
  head/sys/geom/nop/g_nop.c
  head/sys/geom/nop/g_nop.h
Comment 3 commit-hook freebsd_committer 2016-01-12 09:27:08 UTC
A commit references this bug:

Author: trasz
Date: Tue Jan 12 09:27:02 UTC 2016
New revision: 293738
URL: https://svnweb.freebsd.org/changeset/base/293738

Log:
  MFC r289110:

  Make geom_nop(4) collect statistics on all types of BIOs, not just
  reads and writes.

  PR:		kern/198405
  Submitted by:	Matthew D. Fuller <fullermd at over-yonder dot net>
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D3679

Changes:
_U  stable/10/
  stable/10/sbin/geom/class/nop/gnop.8
  stable/10/sys/geom/nop/g_nop.c
  stable/10/sys/geom/nop/g_nop.h