Created attachment 154039 [details] Move singleton specialization to before timer.h inclusion During the exp-run in bug 197395, it was found that net/mediatomb gives errors with clang 3.6.0: http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-11_23h04m51s/logs/errors/mediatomb-0.12.1_12.log This error is because the timer.h header implicitly defines the Timer singleton already, and such a definition cannot be overridden later by a specialization. I propose to fix this by defining the singleton specialization *before* including the timer.h file, as in the attached patch.
This fails to build: http://pd.valinor.palantiri.org/data/84amd64-default/2015-04-01_18h11m14s/logs/errors/mediatomb-0.12.1_12.log So I am returning it to the pool.
A commit references this bug: Author: pi Date: Thu Sep 24 19:49:20 UTC 2015 New revision: 397755 URL: https://svnweb.freebsd.org/changeset/ports/397755 Log: net/mediatomb: remove BROKEN, fix build - now uses UIDs/GIDs - fix build in certain cases PR: 198436, 202467 Submitted by: Pavel Nedoshivkin <nedoshivkin@gmail.com>, dim Approved by: maintainer (timeout) Changes: head/GIDs head/UIDs head/net/mediatomb/Makefile head/net/mediatomb/files/config.xml.dist.in head/net/mediatomb/files/mediatomb.in head/net/mediatomb/files/patch-timer.cc head/net/mediatomb/files/pkg-install.in head/net/mediatomb/pkg-plist