Bug 198560 - [PATCH] x11-wm/xfce4-session: appropriately disable verbose log
Summary: [PATCH] x11-wm/xfce4-session: appropriately disable verbose log
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Duchateau
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-13 08:23 UTC by lichray
Modified: 2015-03-28 20:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xfce)

Attachments
under files/ (468 bytes, text/x-chdr)
2015-03-13 08:23 UTC, lichray 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lichray 2015-03-13 08:23:20 UTC 
Created attachment 154261 [details]
under files/

The upstream change unconditionally logs:

  https://github.com/EricKoegel/xfce4-session/commit/970249c095f31eaeb8f7bb4bb5f835c669c37e57

I read it as a mistake.
Comment 1 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-13 17:36:59 UTC 
I close this PR. I think changes need to be reported upstream.
Comment 2 lichray 2015-03-13 17:40:05 UTC 
(In reply to Olivier Duchateau from comment #1)

It is a good thing to report upstream, but your users need this immediately.
Comment 3 lichray 2015-03-28 17:37:21 UTC 
(In reply to Olivier Duchateau from comment #1)

FYI, already merged in upstream:

  http://git.xfce.org/xfce/xfce4-session/commit/?id=26f9ae8df629f02af0773df2ed82db6b85c5b556
Comment 4 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-28 20:10:58 UTC 
Re-open, approved by upstream.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-03-28 20:28:15 UTC 
A commit references this bug:

Author: olivierd
Date: Sat Mar 28 20:28:10 UTC 2015
New revision: 382552
URL: https://svnweb.freebsd.org/changeset/ports/382552

Log:
  - Add patch, to make verbose logging conditional
  - Bump PORTREVISION

  PR:		198560
  Submitted by:	Zhihao Yuan <lichray@gmail.com>

Changes:
  head/x11-wm/xfce4-session/Makefile
  head/x11-wm/xfce4-session/files/patch-xfce4-session_xfsm-global.h
Comment 6 Olivier Duchateau freebsd_committer freebsd_triage 2015-03-28 20:29:13 UTC 
Committed, thanks!