Bug 198581 - dns/unbound: add aaaa-filter option from contrib patch within the source tarball
Summary: dns/unbound: add aaaa-filter option from contrib patch within the source tarball
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sergey Matveychuk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-14 15:14 UTC by Stéphane Lapie
Modified: 2015-03-16 15:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sem)


Attachments
Adds the AAAA_FILTER option to the config menu, along with patching from the file contrib/aaaa-filter-iterator.patch which is in the unbound source (1.08 KB, patch)
2015-03-14 15:14 UTC, Stéphane Lapie
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Lapie 2015-03-14 15:14:32 UTC
Created attachment 154300 [details]
Adds the AAAA_FILTER option to the config menu, along with patching from the file contrib/aaaa-filter-iterator.patch which is in the unbound source

I have developed a patch recently to implement within unbound functionality similar to BIND's "filter-aaaa" option.
This feature not being readily available is one major reason Japanese ISPs can not leave BIND behind.
(Physical carriers such as NTT roll out their own in-house closed IPv6 routing, over which ISPs have no control, if they don't themselves provide IPv6 service to the customers)

It has been included in unbound's contrib/ starting with the latest version (1.5.1), but was initially developped for version 1.4.17.
The patch applies properly on any version above so far, so I was thinking adding a Makefile option, and a clause in the "post-patch:" section to apply it.

I have included a proposal of Makefile, along with a diff explaining what changes I have done.
I am willing to provide whatever help is required.

I was also wondering one thing, since the binaries generated will
ultimately be quite different, should the option alter the package name?

I have not done so, but I fear a miscalculated port update after tuning
repositories might have dramatic effects, so I thought one way to avoid
the headache would be to have a different package name.

Thanks in advance for your time,
Comment 1 commit-hook freebsd_committer 2015-03-16 14:48:06 UTC
A commit references this bug:

Author: sem
Date: Mon Mar 16 14:47:52 UTC 2015
New revision: 381404
URL: https://svnweb.freebsd.org/changeset/ports/381404

Log:
  - Option to apply contrib/aaaa-filter-iterator.patch

  PR:		198581
  Submitted by:	darksoul@darkbsd.org

Changes:
  head/dns/unbound/Makefile
Comment 2 Stéphane Lapie 2015-03-16 15:29:20 UTC
Thank you, but I just checked the commit ( https://svnweb.freebsd.org/ports/head/dns/unbound/Makefile?view=markup&pathrev=381404
 ) , and found these two things :
- Line 32 : "FILTER_AAA" should be "FILTER_AAAA"
- Line 103 : "at ${WRKSRC}/contrib/aaaa-filter-iterator.patch" should be "cat ${WRKSRC}/contrib/aaaa-filter-iterator.patch"

Also, is it normal to not define a description for FILTER_AAAA ?
Comment 3 Sergey Matveychuk freebsd_committer 2015-03-16 15:37:30 UTC
OMG. So many mistakes. Thanks.