Can be updated. Im add OSS support, integrate few patches from ports, and fix build errors under FreeBSD.
I hope we can get an update soon because the next release of vinagre may require newer version of FreeRDP. https://bugzilla.gnome.org/show_bug.cgi?id=749124
This is not appropriate for a PR: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/problem-reports/pr-when.html "Please do not submit problem reports that simply state that a newer version of an application is available. Ports maintainers are automatically notified by portscout when a new version of an application becomes available. Actual patches to update a port to the latest version are welcome." There is also no maintainer for this port, so without a patch, there is nothing to do. I'm closing the PR.
Ting-Wei Lan: If you want a new version of vinegre, then you'll probably have to do the work to update this port first.
Created attachment 156953 [details] Update to FreeRDP 1.2.0-beta1+android9
reopening
Ting-Wei, The patch looks decent. Do you have any poudriere logs showing that it builds cleanly (with stage-qa checks)?
Created attachment 156954 [details] poudriere testport logs on FreeBSD 10.1 amd64 I have run 'poudriere testport' 9 times to test options on FreeBSD 10.1 amd64. I also ran xfreerdp on my desktop (FreeBSD 10.1), used it to connect to a Windows VM and shared files and the clipboard with the remote host. Updating freerdp to the latest version also fixes the build issue in vinagre master branch. vinagre can successfully connect to the same remote host.
ah, can you upload a plain text version? tar.xz is not convenient on this windows machine. Assuming the log is good, I'll then promote the PR.
There are 9 logs so I uploaded an .tar.xz file. Is a .zip file acceptable?
oh, just upload one log.
Created attachment 156957 [details] poudriere testport plain text log with the default option
okay, great! If somebody wants all the logs they are still available. I'll move this to "patch ready" so hopefully it gets fast-tracked.
Created attachment 156971 [details] Update to FreeRDP 1.2.0-beta1+android9 - USES=execinfo added USES=execinfo is required on FreeBSD 9 and 8.
testing@work
A commit references this bug: Author: pi Date: Sat May 23 16:39:45 UTC 2015 New revision: 387177 URL: https://svnweb.freebsd.org/changeset/ports/387177 Log: net/freerdp: 1.1.0 -> 1.2.0 - The version is known as 1.2.0-beta1+android9 - USES=execinfo is required on FreeBSD 9 and 8 - Fixes build issues PR: 198618 Requested by: rozhuk.im@gmail.com Submitted by: Ting-Wei Lan <lantw44@gmail.com> Changes: head/net/freerdp/Makefile head/net/freerdp/distinfo head/net/freerdp/files/patch-channels-tsmf-client-ffmpeg-tsmf_ffmpeg.c head/net/freerdp/files/patch-client_common_compatibility.c head/net/freerdp/files/patch-git_1b663cef head/net/freerdp/files/patch-git_434436b7 head/net/freerdp/files/patch-libfreerdp-locale-timezone.c head/net/freerdp/pkg-plist
It build on 10.1a, 9.3a, 8.4i, so: Committed, thanks!
What happen with OSS support and others!? https://github.com/ivan-83/FreeRDP/commit/8d5825ee007a7889992d5a01e482d1589dd6a7ee https://github.com/ivan-83/FreeRDP/commit/fe9fab920ebe719d7d7af9a2373a53752b35a20a https://github.com/ivan-83/FreeRDP/commit/4f8f84f33bee4ca69c2145ac4cc67ede4cb120cd https://github.com/ivan-83/FreeRDP/commit/434436b75f00c5475f66ff0f4062e168aa409688 https://github.com/ivan-83/FreeRDP/commit/e85dccc22a891ba03ec9d5b2b1b1b31fc425b34c https://github.com/ivan-83/FreeRDP/commit/f5dbe2c9a5fe050c1d7e014d3c1529befb8eea3b https://github.com/ivan-83/FreeRDP/commit/0f3b6390588a918450677bc2a01b0a64a43bda02 https://github.com/ivan-83/FreeRDP/commit/7b3a5529883f5ab87ff61663178808e286cfd8a0 https://github.com/ivan-83/FreeRDP/commit/3a8022e67cc8c3f2cd068f4d505a6174d2a40e1a https://github.com/ivan-83/FreeRDP/commit/712b5e6174c65da67cf87f06170aa8616d65371f and unmerged: https://github.com/FreeRDP/FreeRDP/pull/2481/files
Thanks, I was not aware of those commits against the FreeRDP github repo. I now tried to build using the latest github commit: GH_ACCOUNT= FreeRDP GH_PROJECT= ${GH_ACCOUNT} GH_TAGNAME= 36cb1e6dc9 but this failed. I then thought: Maybe if I retrieve it from your repo: GH_ACCOUNT= ivan-83 GH_PROJECT= FreeRDP GH_TAGNAME= d325a3cc48 but this failed as well. I can provide build logs. I have no efficient workflow right now that would allow me to include those changes into the port -- do you have an idea on how to do this ? Maybe as a diff against the port itself ?
Show build commands and logs.
build on 10.1amd64 with make check-plist result see http://people.freebsd.org/~pi/logs/freerdp-build-d325a3cc48.txt
Linking C shared library libxfreerdp-client.so CMakeFiles/dfreerdp.dir/dfreerdp.c.o: In function `dfreerdp_run': dfreerdp.c:(.text+0xabe): undefined reference to `freerdp_channels_pop_event' dfreerdp.c:(.text+0xae8): undefined reference to `freerdp_event_new' dfreerdp.c:(.text+0xafb): undefined reference to `freerdp_channels_send_event' dfreerdp.c:(.text+0xb08): undefined reference to `freerdp_event_free' collect2: error: ld returned 1 exit status looks like it try link with old lib from /usr/local/lib Patch: https://github.com/FreeRDP/FreeRDP/pull/2481/files CMakeLists.txt should fix it.
Last code merged: https://github.com/FreeRDP/FreeRDP/pull/2719 OSS audin fixes tsmf added cmdline syntax samples added improve BSD support devd detection and support urbdrc usb fixes
A commit references this bug: Author: pi Date: Sat Jun 27 13:23:25 UTC 2015 New revision: 390700 URL: https://svnweb.freebsd.org/changeset/ports/390700 Log: net/freerdp: update to a newer GIT version which builds without patches https://github.com/FreeRDP/FreeRDP/pull/2719 OSS: audin fixes, tsmf added cmdline: syntax samples added improve BSD support: devd detection and support, urbdrc usb: fixes PR: 198618 Submitted by: Rozhuk Ivan <rozhuk.im@gmail.com> Changes: head/net/freerdp/Makefile head/net/freerdp/distinfo head/net/freerdp/files/ head/net/freerdp/pkg-plist
Test-built on 10.1a, 9.3a, 8.4i, all fine. Committed, thanks for your persistence!
A commit references this bug: Author: pi Date: Sat Jun 27 15:15:19 UTC 2015 New revision: 390719 URL: https://svnweb.freebsd.org/changeset/ports/390719 Log: net/freerdp: fix pkg-plist conditionals PR: 198618 Pointy hat to: pi Changes: head/net/freerdp/Makefile head/net/freerdp/pkg-plist
This update breaks vinagre build on FreeBSD 10.1: Package libssl was not found in the pkg-config search path. Perhaps you should add the directory containing `libssl.pc' to the PKG_CONFIG_PATH environment variable Package 'libssl', required by 'winpr', not found Package 'libssl', required by 'freerdp', not found
Build log found in freebsd-gnome mailing list https://lists.freebsd.org/pipermail/freebsd-gnome/2015-June/032505.html
Dont see OSS sound system and other patches. https://github.com/FreeRDP/FreeRDP/pull/2719 - last patch with OSS. freerdp-1.2.0_5 GH_TAGNAME= f5ff6e1 It would be nice to add options: CHANNEL_AUDIN:BOOL=ON CHANNEL_RDPSND:BOOL=ON CHANNEL_TSMF:BOOL=ON WITH_OSS:BOOL=ON WITH_ALSA:BOOL=ON WITH_PULSE:BOOL=OFF CHANNEL_DRIVE:BOOL=ON CHANNEL_PARALLEL:BOOL=ON CHANNEL_SERIAL:BOOL=ON CHANNEL_PRINTER:BOOL=OFF CHANNEL_SMARTCARD:BOOL=ON CHANNEL_URBDRC:BOOL=OFF WITH_CUPS:BOOL=OFF WITH_DIRECTFB:BOOL=OFF WITH_FFMPEG:BOOL=ON WITH_MANPAGES:BOOL=ON WITH_SSE2:BOOL=ON WITH_XINERAMA:BOOL=ON WITH_XRANDR:BOOL=ON WITH_XRENDER:BOOL=ON WITH_XSHM:BOOL=ON WITH_XV:BOOL=ON
Created attachment 168204 [details] newer-patch testbuilds of depends are OK: multimedia/vlc net/vinagre net/guacamole-server net/xrdp-devel net/krdc
Created attachment 168263 [details] patch-v3 New version, fixes pkgconfig stuff
Created attachment 168269 [details] patch-v4
I test-build vinagre with the newer freerdp version and it build and ran and connected to some win7 host.
The working build was with a buggy pkgconfig. TODO: find a patch that works and has a working pkgconfig.
(In reply to Kurt Jaeger from comment #33) See http://people.freebsd.org/~pi/logs/guacamole-server-0.9.9_1.log and vinagre-3.18.2.log
Created attachment 171314 [details] Patch to update net/freerdp to f818bab (devel version of 2.0.0) and add net/vinagre patches This patch updates net/freerdp to a development version of 2.0.0 (f818bab) and ensures the man pages and pkgconfig are installed in the right place. It also adds two patches to allow net/vinagre to successfully build with this update. Note that the following ports have non-default options to enable FREERDP, and do not yet build with this change: net/guacamole-server net/krdc The following ports have commented out dependencies or options for FREERDP, but already fail with the current version of freerd. They also fail with this update. multimedia/vlc net/xrdp-devel
Ben, please work on it, I really appreciate if you do it!
Skipped missing target: 'net/freerdp/files/patch-CMakeLists.txt' Skipped missing target: 'net/freerdp/files/patch-cmake_FindGStreamer__1__0.cmake' Skipped missing target: 'net/freerdp/files/patch-libfreerdp_freerdp.pc.in' Skipped missing target: 'net/freerdp/files/patch-winpr_winpr.pc.in' Summary of conflicts: Skipped paths: 4
*** This bug has been marked as a duplicate of bug 212004 ***