Can be updated.
Im add OSS support, integrate few patches from ports, and fix build errors under FreeBSD.
I hope we can get an update soon because the next release of vinagre may require newer version of FreeRDP.
This is not appropriate for a PR:
"Please do not submit problem reports that simply state that a newer version of an application is available. Ports maintainers are automatically notified by portscout when a new version of an application becomes available. Actual patches to update a port to the latest version are welcome."
There is also no maintainer for this port, so without a patch, there is nothing to do. I'm closing the PR.
Ting-Wei Lan: If you want a new version of vinegre, then you'll probably have to do the work to update this port first.
Created attachment 156953 [details]
Update to FreeRDP 1.2.0-beta1+android9
The patch looks decent. Do you have any poudriere logs showing that it builds cleanly (with stage-qa checks)?
Created attachment 156954 [details]
poudriere testport logs on FreeBSD 10.1 amd64
I have run 'poudriere testport' 9 times to test options on FreeBSD 10.1 amd64. I also ran xfreerdp on my desktop (FreeBSD 10.1), used it to connect to a Windows VM and shared files and the clipboard with the remote host.
Updating freerdp to the latest version also fixes the build issue in vinagre master branch. vinagre can successfully connect to the same remote host.
ah, can you upload a plain text version? tar.xz is not convenient on this windows machine.
Assuming the log is good, I'll then promote the PR.
There are 9 logs so I uploaded an .tar.xz file.
Is a .zip file acceptable?
oh, just upload one log.
Created attachment 156957 [details]
poudriere testport plain text log with the default option
okay, great! If somebody wants all the logs they are still available. I'll move this to "patch ready" so hopefully it gets fast-tracked.
Created attachment 156971 [details]
Update to FreeRDP 1.2.0-beta1+android9 - USES=execinfo added
USES=execinfo is required on FreeBSD 9 and 8.
A commit references this bug:
Date: Sat May 23 16:39:45 UTC 2015
New revision: 387177
net/freerdp: 1.1.0 -> 1.2.0
- The version is known as 1.2.0-beta1+android9
- USES=execinfo is required on FreeBSD 9 and 8
- Fixes build issues
Requested by: email@example.com
Submitted by: Ting-Wei Lan <firstname.lastname@example.org>
It build on 10.1a, 9.3a, 8.4i, so: Committed, thanks!
What happen with OSS support and others!?
Thanks, I was not aware of those commits against the FreeRDP github repo.
I now tried to build using the latest github commit:
but this failed.
I then thought: Maybe if I retrieve it from your repo:
but this failed as well. I can provide build logs.
I have no efficient workflow right now that would allow me to include
those changes into the port -- do you have an idea on how to do this ?
Maybe as a diff against the port itself ?
Show build commands and logs.
build on 10.1amd64 with
result see http://people.freebsd.org/~pi/logs/freerdp-build-d325a3cc48.txt
Linking C shared library libxfreerdp-client.so
CMakeFiles/dfreerdp.dir/dfreerdp.c.o: In function `dfreerdp_run':
dfreerdp.c:(.text+0xabe): undefined reference to `freerdp_channels_pop_event'
dfreerdp.c:(.text+0xae8): undefined reference to `freerdp_event_new'
dfreerdp.c:(.text+0xafb): undefined reference to `freerdp_channels_send_event'
dfreerdp.c:(.text+0xb08): undefined reference to `freerdp_event_free'
collect2: error: ld returned 1 exit status
looks like it try link with old lib from /usr/local/lib
Patch: https://github.com/FreeRDP/FreeRDP/pull/2481/files CMakeLists.txt
should fix it.
Last code merged: https://github.com/FreeRDP/FreeRDP/pull/2719
syntax samples added
improve BSD support
devd detection and support
A commit references this bug:
Date: Sat Jun 27 13:23:25 UTC 2015
New revision: 390700
net/freerdp: update to a newer GIT version which builds without patches
OSS: audin fixes, tsmf added
cmdline: syntax samples added
improve BSD support: devd detection and support, urbdrc
Submitted by: Rozhuk Ivan <email@example.com>
Test-built on 10.1a, 9.3a, 8.4i, all fine.
Committed, thanks for your persistence!
A commit references this bug:
Date: Sat Jun 27 15:15:19 UTC 2015
New revision: 390719
net/freerdp: fix pkg-plist conditionals
Pointy hat to: pi
This update breaks vinagre build on FreeBSD 10.1:
Package libssl was not found in the pkg-config search path.
Perhaps you should add the directory containing `libssl.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libssl', required by 'winpr', not found
Package 'libssl', required by 'freerdp', not found
Build log found in freebsd-gnome mailing list
Dont see OSS sound system and other patches.
https://github.com/FreeRDP/FreeRDP/pull/2719 - last patch with OSS.
It would be nice to add options:
Created attachment 168204 [details]
testbuilds of depends are OK:
Created attachment 168263 [details]
New version, fixes pkgconfig stuff
Created attachment 168269 [details]
I test-build vinagre with the newer freerdp version and it build and ran and connected to some win7 host.
The working build was with a buggy pkgconfig. TODO: find a patch that works and has a working pkgconfig.
(In reply to Kurt Jaeger from comment #33)
Created attachment 171314 [details]
Patch to update net/freerdp to f818bab (devel version of 2.0.0) and add net/vinagre patches
This patch updates net/freerdp to a development version of 2.0.0 (f818bab) and ensures the man pages and pkgconfig are installed in the right place.
It also adds two patches to allow net/vinagre to successfully build with this update.
Note that the following ports have non-default options to enable FREERDP, and do not yet build with this change:
The following ports have commented out dependencies or options for FREERDP, but already fail with the current version of freerd. They also fail with this update.
Ben, please work on it, I really appreciate if you do it!
Skipped missing target: 'net/freerdp/files/patch-CMakeLists.txt'
Skipped missing target: 'net/freerdp/files/patch-cmake_FindGStreamer__1__0.cmake'
Skipped missing target: 'net/freerdp/files/patch-libfreerdp_freerdp.pc.in'
Skipped missing target: 'net/freerdp/files/patch-winpr_winpr.pc.in'
Summary of conflicts:
Skipped paths: 4
*** This bug has been marked as a duplicate of bug 212004 ***