Created attachment 154465 [details] update to 0.4.0 I've patched my local version to use the most recent 0.4.0 version and also depend on qt5. Note that I'm use git to fetch the ports not svn so the diff is generated with "git diff". Also the pathc in "files" was removed as its no longer needed, and no patches in "/files" are needed for this version. % portlint looks fine. % make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) % make stage-qa ====> Running Q/A tests (stage-qa) % As a side note this update enables mail/trojita port to use "-DWITH_QTKEYCHAIN_PLUGIN:STRING=ON"
Currently, the only user of this port is deskutils/mirall, which is using Qt 4 for now. With your update mirall would depend on both Qt 4 and Qt 5, and i'm not sure if it's OK. So, if the ports commiter don't see a problem with this, then i'm OK with the patch too.
I noticed mirall but it as no maintainer and the package was renamed by owncloud to "client" (at least in github, and stable is now 1.8.0) In any case I agree ideally it should just depend on qt5, but maybe it can be built with the same qt5 deps with no issues (I'll test locally)
Or.. I guess I can add an option to use qt5 or qt4... Or maybe a different port, one being a master... what would be the preferred way? Btw It seems "owncloud client" also can be build with both qt4 and qt5 (https://github.com/owncloud/client/blob/fba9020950271f8ea5e594fa412f645fb0575636/cmake/modules/QtVersionAbstraction.cmake)
I've created another PR [1] to update both mirall and qtkeychain to their most recent version and to use Qt 5, so this PR is not actual anymore. Thanks for bringing this up, though. [1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198785
Awesome, thanks
Marking as duplicated of maintainer submitted patch. Thanks. *** This bug has been marked as a duplicate of bug 198785 ***