Bug 198712 - [New port] devel/libvterm: library implementation of a VT220/xterm/ECMA-48 terminal emulator
Summary: [New port] devel/libvterm: library implementation of a VT220/xterm/ECMA-48 te...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks: 198713
  Show dependency tree / graph
 
Reported: 2015-03-19 16:58 UTC by Anton Törnqvist
Modified: 2015-05-28 09:59 UTC (History)
1 user (show)

See Also:

Attachments
libvterm.shar (2.52 KB, application/x-shar)
2015-03-19 16:58 UTC, Anton Törnqvist 		no flags Details
poudriere-buildlog-10amd64-libvterm (10.94 KB, text/plain)
2015-03-19 16:58 UTC, Anton Törnqvist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Törnqvist 2015-03-19 16:58:13 UTC 
Created attachment 154529 [details]
libvterm.shar
Comment 1 Anton Törnqvist 2015-03-19 16:58:37 UTC 
Created attachment 154530 [details]
poudriere-buildlog-10amd64-libvterm
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-27 15:36:10 UTC 
Likewise, suggested changes:

- use date instead of fake version in PORTVERSION
- add LICENSE_FILE
- properly use github (change distinfo)
- strip unversioned .so

diff -ruN libvterm.orig/Makefile libvterm/Makefile
--- libvterm.orig/Makefile      2015-05-27 18:33:39.535858000 +0300
+++ libvterm/Makefile   2015-05-27 18:31:18.886569000 +0300
@@ -2,18 +2,18 @@
 # $FreeBSD$
 
 PORTNAME=      libvterm
-PORTVERSION=   0.0.1
+PORTVERSION=   git20150527
 CATEGORIES=    devel
-MASTER_SITES=  http://github.com/neovim/libvterm/archive/
-COMMIT=                1b745d29d45623aa8d22a7b9288c7b0e331c7088
-DISTFILES=     ${COMMIT}.tar.gz
 
 MAINTAINER=    antont@inbox.lv
 COMMENT=       Implementation of a VT220/xterm/ECMA-48 terminal emulator
 
 LICENSE=       MIT
+LICENSE_FILE=  ${WRKSRC}/LICENSE
 
-WRKSRC=                ${WRKDIR}/${PORTNAME}-${COMMIT}
+USE_GITHUB=    yes
+GH_ACCOUNT=    neovim
+GH_TAGNAME=    1b745d2
 
 USES=          gmake libtool:build perl5
 USE_LDCONFIG=  yes
@@ -21,10 +21,10 @@
 pre-build:
        ${REINPLACE_CMD} -e 's|$$(LIBDIR)/pkgconfig|${PREFIX}/libdata/pkgconfig|g' ${WRKSRC}/Makefile
 
-post-stage:
-       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libvterm.so.0.0.0
-       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/vterm-dump
-       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/vterm-ctrl
+post-install:
        ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/unterm
+       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/vterm-ctrl
+       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/vterm-dump
+       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libvterm.so
 
 .include <bsd.port.mk>
diff -ruN libvterm.orig/distinfo libvterm/distinfo
--- libvterm.orig/distinfo      2015-05-27 18:33:39.533526000 +0300
+++ libvterm/distinfo   2015-05-27 18:30:56.496999000 +0300
@@ -1,2 +1,2 @@
-SHA256 (1b745d29d45623aa8d22a7b9288c7b0e331c7088.tar.gz) = 3fc75908256c0d158d6c2a32d39f34e86bfd26364f5404b7d9c03bb70cdc3611
-SIZE (1b745d29d45623aa8d22a7b9288c7b0e331c7088.tar.gz) = 63733
+SHA256 (neovim-libvterm-git20150527-1b745d2_GH0.tar.gz) = fb9e25065f764cf23d0947cd17c9abd941fc1a22e0cd5e42d7ad59b3ff1f093f
+SIZE (neovim-libvterm-git20150527-1b745d2_GH0.tar.gz) = 63714
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-05-28 09:33:26 UTC 
Is submitter OK with these changes?
Comment 4 Anton Törnqvist 2015-05-28 09:40:11 UTC 
(In reply to Dmitry Marakasov from comment #3)

I approve
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-05-28 09:59:55 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu May 28 09:58:56 UTC 2015
New revision: 387715
URL: https://svnweb.freebsd.org/changeset/ports/387715

Log:
  Abstract C99 library which implements a VT220 or xterm-like terminal emulator.
  It doesn't use any particular graphics toolkit or output system,
  instead it invokes callback function pointers that its
  embedding program should provide it to draw on its behalf.
  It avoids calling malloc() during normal running state,
  allowing it to be used in embedded kernel situations.

  WWW: http://www.leonerd.org.uk/code/libvterm/

  PR:		198712
  Submitted by:	antont@inbox.lv

Changes:
  head/devel/Makefile
  head/devel/libvterm/
  head/devel/libvterm/Makefile
  head/devel/libvterm/distinfo
  head/devel/libvterm/pkg-descr
  head/devel/libvterm/pkg-plist