Bug 198726 - usr.bin/grep is not tested unless WITH_BSD_GREP is set
Summary: usr.bin/grep is not tested unless WITH_BSD_GREP is set
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-testing (Nobody)
Depends on:
Reported: 2015-03-20 05:19 UTC by Stefan Grundmann
Modified: 2020-12-08 19:31 UTC (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Grundmann 2015-03-20 05:19:38 UTC
the test script in contrib/netbsd-tests/usr.bin/grep/ calls grep which is
GNU grep from gnu/usr.bin/grep/ unless WITH_BSD_GREP is set.
Comment 1 Stefan Grundmann 2015-03-20 11:17:48 UTC
this would have caught bug #198725 (bsdgrep -f broken since r268799)
Comment 2 Ed Maste freebsd_committer 2017-05-17 13:23:40 UTC
I suspect the way to solve this is for us to add a CI test instance that has WITH_BSD_GREP set in the short term (and later make WITH_BSD_GREP the default, and then remove unused GNU grep).
Comment 3 Kyle Evans freebsd_committer 2017-05-17 13:59:27 UTC
(In reply to Ed Maste from comment #2)

Agreed. Unfortunately this isn't easy to otherwise solve in a way that doesn't require a fairly major restructure of the NetBSD tests, and I don't think the result of that would be very upstream-able.
Comment 4 Enji Cooper freebsd_committer 2017-05-18 01:22:05 UTC
(In reply to Kyle Evans from comment #3)

There's a way... I'd just prefer not hacking t_grep.sh too badly. I'll mull it over a bit though...
Comment 5 Stefan Grundmann 2020-12-08 19:31:39 UTC
since r368439 BSD_GREP is default.