Bug 198729 - [MAINTAINER] games/wxlauncher: Update Git commit for 0.9.5 release version
Summary: [MAINTAINER] games/wxlauncher: Update Git commit for 0.9.5 release version
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-20 10:45 UTC by lightside
Modified: 2015-04-13 21:03 UTC (History)
0 users

See Also:


Attachments
Proposed patch (since 379636 revision) (987 bytes, patch)
2015-03-20 10:45 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (9.39 KB, application/x-bzip2)
2015-03-20 12:11 UTC, lightside
no flags Details
Proposed patch (since 379636 revision) (1.01 KB, patch)
2015-03-20 12:33 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (9.39 KB, application/x-bzip2)
2015-03-20 12:34 UTC, lightside
no flags Details
Proposed patch (since 379636 revision) (1.42 KB, patch)
2015-03-21 06:55 UTC, lightside
lightside: maintainer-approval+
Details | Diff
Proposed patch (since 379636 revision) (1.09 KB, patch)
2015-03-26 15:04 UTC, lightside
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2015-03-20 10:45:05 UTC
Created attachment 154561 [details]
Proposed patch (since 379636 revision)

Patch to update the Git commit for games/wxlauncher port, which was changed for 0.9.5 release version:
https://github.com/wxLauncher/wxlauncher/tree/release-0.9.5

This also fixes warning after ports r381618 changes.
Comment 1 lightside 2015-03-20 12:11:57 UTC
Created attachment 154564 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 2 lightside 2015-03-20 12:33:55 UTC
Created attachment 154566 [details]
Proposed patch (since 379636 revision)

Looks like, there is a need to use DISTVERSIONSUFFIX=-${GH_TAGNAME} for this case, because of different distfile for the same PORTVERSION.
Comment 3 lightside 2015-03-20 12:34:17 UTC
Created attachment 154567 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 4 lightside 2015-03-20 18:24:29 UTC
Comment on attachment 154566 [details]
Proposed patch (since 379636 revision)

(In reply to comment #3)
> Looks like, there is a need to use DISTVERSIONSUFFIX=-${GH_TAGNAME} for this case.

No, it's not needed, because of "_GH0" postfix already.
Comment 5 lightside 2015-03-21 06:55:11 UTC
Created attachment 154613 [details]
Proposed patch (since 379636 revision)

Let's use GitHub API:
https://developer.github.com/v3/repos/contents/#get-archive-link
Comment 6 lightside 2015-03-26 15:04:34 UTC
Created attachment 154830 [details]
Proposed patch (since 379636 revision)

I think, there is a (general) misunderstanding about GitHub API (front-end) usage. But also there is a possible reviewer's abuse of conversion from (correct) MASTER_SITES to USE_GITHUB. Therefore, return to use USE_GITHUB with correct DISTNAME (where the current "_GH0" part is responsibility of other people; therefore, if it changed outside of the port, then recreate the distinfo file with "make makesum" command).
Comment 7 lightside 2015-04-13 21:03:41 UTC
Superseded by bug 199429.