Bug 198742 - www/varnish -- allow easily setting varnishncsa log format
Summary: www/varnish -- allow easily setting varnishncsa log format
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-20 15:37 UTC by Matthew Seaman
Modified: 2015-03-23 16:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (feld)


Attachments
Changes to the www/varnish port (1.46 KB, patch)
2015-03-20 15:37 UTC, Matthew Seaman
no flags Details | Diff
poudriere testport output with the patch applied (264.74 KB, text/plain)
2015-03-20 15:37 UTC, Matthew Seaman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Seaman freebsd_committer 2015-03-20 15:37:19 UTC
Created attachment 154581 [details]
Changes to the www/varnish port

Here's a small patch to ${LOCALBASE}/etc/rc.d/varnishncsa which allows users to easily control the log format used by varnishncsa, simply by defining varnishncsa_logformat in /etc/rc.conf

The default value for varnishncsa_logformat is an empty variable, which results in varnishncsa using its built-in default log format.  There's no change in behaviour of the varnish port unless the user sets varnishncsa_logformat to a non-empty value.
Comment 1 Matthew Seaman freebsd_committer 2015-03-20 15:37:53 UTC
Created attachment 154582 [details]
poudriere testport output with the patch applied
Comment 2 commit-hook freebsd_committer 2015-03-23 16:28:26 UTC
A commit references this bug:

Author: feld
Date: Mon Mar 23 16:27:38 UTC 2015
New revision: 382013
URL: https://svnweb.freebsd.org/changeset/ports/382013

Log:
  Allow configuration of the varnishncsa log format

  PR:		198742

Changes:
  head/www/varnish/Makefile
  head/www/varnish/files/varnishncsa.in
  head/www/varnish4/Makefile
  head/www/varnish4/files/varnishncsa.in
Comment 3 Mark Felder freebsd_committer 2015-03-23 16:29:56 UTC
committed, thanks!