Bug 198765 - [PATCH] www/links: Make EGD conditional/Fix build with LibreSSL
Summary: [PATCH] www/links: Make EGD conditional/Fix build with LibreSSL
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-21 12:47 UTC by Bernard Spil
Modified: 2016-07-02 10:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bf)


Attachments
svn diff for www/links (729.66 KB, patch)
2015-03-21 12:47 UTC, Bernard Spil
no flags Details | Diff
Poudriere build log for www/links (36.15 KB, text/plain)
2015-03-21 12:48 UTC, Bernard Spil
no flags Details
svn diff for www/links (6.56 KB, patch)
2015-04-25 10:57 UTC, Bernard Spil
no flags Details | Diff
Poudriere build log for www/links (35.34 KB, text/plain)
2015-04-25 10:58 UTC, Bernard Spil
no flags Details
svn diff for www/links 2.9,1 (6.56 KB, patch)
2015-04-27 14:30 UTC, Bernard Spil
no flags Details | Diff
Poudriere build log for www/links 2.9,1 (32.79 KB, text/plain)
2015-04-27 14:31 UTC, Bernard Spil
no flags Details
svn diff for www/links 2.9,1 (1.14 KB, patch)
2015-10-24 11:10 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2015-03-21 12:47:57 UTC
Created attachment 154620 [details]
svn diff for www/links

www/links unconditionally relies on RAND_egd which makes building fail with LibreSSL which has removed EGD. FreeBSD does not require EGD at all, /dev/random has been available since FreeBSD 4.2

This patch checks for the existence of RAND_egd in libcrypto and disables the code using egd.
Comment 1 Bernard Spil freebsd_committer 2015-03-21 12:48:17 UTC
Created attachment 154621 [details]
Poudriere build log for www/links
Comment 2 Brendan Fabeny freebsd_committer 2015-04-25 09:40:20 UTC
I agree that we want to support LibreSSL, but this patch is far too large and unwieldy.  I'll advise upstream of the problem, and distill a smaller set of changes from the patch.
Comment 3 Bernard Spil freebsd_committer 2015-04-25 10:57:11 UTC
Created attachment 155969 [details]
svn diff for www/links

Hi Brendan,

The large patch is largely due to the autoconf version of the included configure script
+-# Generated automatically using autoconf version 2.13 
++# Generated by GNU Autoconf 2.69.
I've refactored the patch so configure only adds the libcrypto RAND_egd check making the patch a lot smaller. Works fine here!
Comment 4 Bernard Spil freebsd_committer 2015-04-25 10:58:06 UTC
Created attachment 155970 [details]
Poudriere build log for www/links
Comment 5 Bernard Spil freebsd_committer 2015-04-27 14:30:08 UTC
Created attachment 156043 [details]
svn diff for www/links 2.9,1

Patch updated for 2.9,1
Comment 6 Bernard Spil freebsd_committer 2015-04-27 14:31:57 UTC
Created attachment 156044 [details]
Poudriere build log for www/links 2.9,1
Comment 7 Bernard Spil freebsd_committer 2015-10-24 11:10:54 UTC
Created attachment 162413 [details]
svn diff for www/links 2.9,1

After the addition of the OPENSSL_NO_EGD define the patch can be greatly reduced as requested by maintainer.
Comment 8 Rene Ladan freebsd_committer 2016-06-27 21:49:37 UTC
Maintainer reset.
Comment 9 Bernard Spil freebsd_committer 2016-07-02 10:17:56 UTC
Version 2.13 fixes building without RAND_egd