This port is locked into PHP53 as the only version of php that tclink supports. I kind of doubt that is the case, but if the issue is not resolved ASAP, the port will be removed with PHP53. If version 4.0.2 really is limited to php53, then a new version that supports current versions of PHP is needed ASAP.
Created attachment 154709 [details] Removes depends for PHP53
Thanks John. Just took a look, and I'm not exactly clear as to what motivated inclusion of the DEFAULT_PHP_VER value in the first place. Removed and tested on a 10.1 amd64 host, and everything looks peachy. $ php -i | grep -e "PHP Version" -e TCL PHP Version => 5.4.33 PHP Version => 5.4.33 TCLink PHP Module => 4.0.2-PHP-FreeBSD-amd64
Sorry, this is not going to work. 1) The patch doesn't apply. That line doesn't even exist in the port now. 2) All this intends to do is remove restriction, but you didn't address why the php53 restriction was there to begin with. Either it never should have been restricted to php53 (a previous big error) or it really is restricted to 53, and removing the restriction isn't going to fix it (another big error) So we need a current patch and an explanation why it was set to php 5.3 currently.
(In reply to mbowie from comment #2) > Just took a look, and I'm not exactly clear as to what motivated inclusion of > the DEFAULT_PHP_VER value in the first place. okay, but 5.6 is the default, you need to check it for 5.5 and 5.6 (or at least 5.6) we cross posted.
you don't need to provide another patch -- just confirm that it works on 5.6 and I'll remove the line that blocks it from php 5.4, 5.5, and 5.6
Thanks John, sorry for the futz. Admittedly, my familiarity with PHP (and ports for that matter) is well dated now, so I appreciate the context. Quick checks of adding lang/php55 and lang/php56, and recompiling for each, and all appears well. Let me know if there's anything else I should be looking to clear up here. Mike. $ php -i | grep -e "PHP Version" -e TCL PHP Version => 5.5.17 PHP Version => 5.5.17 TCLink PHP Module => 4.0.2-PHP-FreeBSD-amd64 $ php -i | grep -e "PHP Version" -e TCL PHP Version => 5.6.0 PHP Version => 5.6.0 TCLink PHP Module => 4.0.2-PHP-FreeBSD-amd64
A commit references this bug: Author: marino Date: Mon Mar 23 17:55:03 UTC 2015 New revision: 382019 URL: https://svnweb.freebsd.org/changeset/ports/382019 Log: finance/php-tclink: Confirmed functional for all PHP versions The maintainer confirmed that the limitation of tclink to php 5.3 was an error and that it functions on all supported versions of PHP. As a result, the port's deprecation tag has been removed. PR: 198778 Changes: head/finance/php-tclink/Makefile
Okay, thanks. You know, the limit to php53 meant tclink was not available as a binary package. With this latest commit, it will start building in the official builders.
Assign to committer