Bug 198932 - add metadata from add-plist-buildinfo target in bsd.port.mk to PKG_NOTES
Summary: add metadata from add-plist-buildinfo target in bsd.port.mk to PKG_NOTES
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-26 19:10 UTC by Jason Helfman
Modified: 2015-03-27 14:59 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer 2015-03-26 19:10:07 UTC
I had submitted a patch in bug 162397 to add this target to bsd.port.mk, and worked quiet well while using tinderbox. It is possible that the target may need to change if the variables in it are not found in pourdiere:

.if !target(add-plist-buildinfo)
add-plist-buildinfo:
.if defined(PACKAGE_BUILDING)
        @${ECHO_CMD} "@comment Build details:  ${BUILDHOST}|${JAIL}|${BUILD}|${PORTSTREE}|${BUILDDATE}" >> ${TMPPLIST}
.endif
.endif

This information can be tuned to supply more information, or less, depending how we feel it would best suit our/customer needs.

From an IRC chat: it is quite possible a build server could produce bad        packages, and possible that on Monday 10.1-amd64 is built on beefy1 while on Wednesday it is build on beefy8 and produce a broken package. Unlikely, but possible.
Comment 1 Bryan Drewery freebsd_committer 2015-03-26 19:17:47 UTC
The problem here is that add-plist-buildinfo was removed for staged ports.

It needs to be rewritten to use PKG_NOTES instead.
Comment 2 Mathieu Arnold freebsd_committer 2015-03-26 22:33:13 UTC
I feel the best way for tinderbox to do this would be to set USE_LOCAL_MK in the environment/make.conf and replace Mk/bsd.local.mk with one containing whatever targets/variables tinderbox needs.
Comment 3 Bryan Drewery freebsd_committer 2015-03-27 14:59:42 UTC
Bapt brought up an excellent point on IRC. Anything we do here needs to generate packages that are reproducible.