Bug 199009 - x11-fm/thunar : won't display svg previews without librsvg2 installed
Summary: x11-fm/thunar : won't display svg previews without librsvg2 installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-29 20:46 UTC by John Marino
Modified: 2015-03-30 20:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xfce)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2015-03-29 20:46:08 UTC
The Thunar file manager wasn't displaying previews for svg icons.  It turns out that graphics/librsvg2 has to be installed as a runtime dependency.

I had the same exact problem on my port, devel/gps.  This is what I am doing to fix it:

RUN_DEPENDS= rsvg-convert:${PORTSDIR}/graphics/librsvg2

In reality, what is needed I think is "lib/gdk-pixbuf-2.0/%%GTK2_VERSION%%/loaders/libpixbufloader-svg.so" but this makes the RUN_DEPENDS tricky so I just picked an easy file to pull in the package as a run depends.

When this librsvg2 library is installed, thunar displays svg icons fine.
Comment 1 Olivier Duchateau freebsd_committer 2015-03-29 21:17:15 UTC
(In reply to John Marino from comment #0)

By default Thunar does not display any preview, it's deskutils/xfce4-tumbler. It already load gdkpixbuf2, librsvg2 is probably missing.

Feel free to add librsvg2 into deskutils/xfce4-tumbler port.

It's not necessary to use:

RUN_DEPENDS= rsvg-convert:${PORTSDIR}/graphics/librsvg2

Mk/bsd.gnome.mk provides librsvg2 detection, simply adjust USE_GNOME macro.
Comment 2 John Marino freebsd_committer 2015-03-29 21:22:39 UTC
okay, well, I'm only reporting a problem and suggested a fix.  I trust your fix is better, and I'd prefer not to touch your ports right now.  I've got some issues with a specific portmgr that I need to iron out first.
Comment 3 John Marino freebsd_committer 2015-03-29 21:24:57 UTC
P.S.

I just looked at bsd.gnome.mk, it sets LIB_DEPENDS.

At least for GPS, I need RUN_DEPENDS.  It's not a build dependency.
Comment 4 Olivier Duchateau freebsd_committer 2015-03-30 18:31:11 UTC
(In reply to John Marino from comment #2)

I looked at source code, tumbler uses mainly gdkpixbuf functions, I prefer to use librsvg2 into USE_GNOME.
Comment 5 commit-hook freebsd_committer 2015-03-30 18:42:00 UTC
A commit references this bug:

Author: olivierd
Date: Mon Mar 30 18:41:11 UTC 2015
New revision: 382706
URL: https://svnweb.freebsd.org/changeset/ports/382706

Log:
  Allow Thunar (through tumbler daemon) to display previews for SVG icons.

  PR:		199009
  Submitted by:	marino@

Changes:
  head/deskutils/xfce4-tumbler/Makefile
Comment 6 Olivier Duchateau freebsd_committer 2015-03-30 20:29:42 UTC
Committed, thanks!